Skip to content

R2dbcAutoConfiguration does not seem to allow setting metricsRecorder on ConnectionPool and/or ConnectionPoolConfiguration#customizer #40521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
62mkv opened this issue Apr 25, 2024 · 1 comment
Closed

R2dbcAutoConfiguration does not seem to allow setting metricsRecorder on ConnectionPool and/or ConnectionPoolConfiguration#customizer #40521

62mkv opened this issue Apr 25, 2024 · 1 comment
Labels
status: duplicate A duplicate of another issue

Comments

@62mkv
Copy link
Contributor

62mkv commented Apr 25, 2024

I want to enable metrics collection for R2dbc ConnectionPool, have checked the code of org.springframework.boot.autoconfigure.r2dbc.ConnectionFactoryConfigurations.PoolConfiguration and it looks like neither metricsRecorder nor a customizer can be auto-configured on a ConnectionPoolConfiguration.Builder used to build a ConnectionFactory.

this is per Spring Boot 3.2.5. Can this be addressed? or is there any other recommended way to achieve such effect?
@62mkv 62mkv changed the title R2dbcAutoConfiguration does not seem to allow setting metricsRecorder and/or ConnectionPool#customizer R2dbcAutoConfiguration does not seem to allow setting metricsRecorder and/or ConnectionPoolConfiguration#customizer Apr 25, 2024
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Apr 25, 2024
@62mkv 62mkv changed the title R2dbcAutoConfiguration does not seem to allow setting metricsRecorder and/or ConnectionPoolConfiguration#customizer R2dbcAutoConfiguration does not seem to allow setting metricsRecorder on ConnectionPool and/or ConnectionPoolConfiguration#customizer Apr 25, 2024
@philwebb philwebb changed the title R2dbcAutoConfiguration does not seem to allow setting metricsRecorder on ConnectionPool and/or ConnectionPoolConfiguration#customizer R2dbcAutoConfiguration does not seem to allow setting metricsRecorder on ConnectionPool and/or ConnectionPoolConfiguration#customizer Apr 25, 2024
@philwebb
Copy link
Member

I think this is a duplicate of #40010. I'm afraid for now the only option is to define your own ConnectionPool bean.

@philwebb philwebb added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Apr 25, 2024
@philwebb philwebb closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@philwebb @62mkv @spring-projects-issues