Skip to content

Automatically activate health probes in Cloud Foundry environments #39804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vchrisb opened this issue Feb 29, 2024 · 2 comments
Closed

Automatically activate health probes in Cloud Foundry environments #39804

vchrisb opened this issue Feb 29, 2024 · 2 comments
Assignees
Labels
theme: actuator Issues related to actuator and the management context type: enhancement A general enhancement
Milestone

Comments

@vchrisb
Copy link

vchrisb commented Feb 29, 2024

Recent version of cloud foundry do support in addition to an application health check also readiness check, like kubernetes does: https://docs.cloudfoundry.org/devguide/deploy-apps/manifest-attributes.html#readiness-health-check-type

Currently the health probes, LivenessStateHealthIndicator and ReadinessStateHealthIndicator are only automatically enabled in Kubernetes environments: https://docs.spring.io/spring-boot/docs/current/reference/html/actuator.html#actuator.endpoints.kubernetes-probes

By manually configuring management.endpoint.health.probes.enabled=true one can activate these probes and its corresponding endpoints, /actuator/health/liveness and /actuator/health/readiness, for cloud foundry health checks.

The ask is, to not only activate the health probes automatically in kubernetes but also in cloud foundry environments.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 29, 2024
@scottfrederick
Copy link
Contributor

scottfrederick commented Feb 29, 2024

@vchrisb What versions of Cloud Foundry support application health and readiness checks? Should the health probes only be enabled automatically if the Cloud Foundry version is at a certain level?

@scottfrederick scottfrederick added the status: waiting-for-feedback We need additional information before we can continue label Feb 29, 2024
@vchrisb
Copy link
Author

vchrisb commented Feb 29, 2024

It is supported from cf-deployment v32.2.0 or TAS 5.0.0

From a cloud foundry perspective it could be enabled always, though the readiness endpoint is only usable starting with the before mentioned version.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Feb 29, 2024
@philwebb philwebb added the for: team-meeting An issue we'd like to discuss as a team to make progress label Apr 22, 2024
@philwebb philwebb changed the title Automatically activate health probes in cloud foundry environments Automatically activate health probes in Cloud Foundry environments May 6, 2024
@philwebb philwebb added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided for: team-meeting An issue we'd like to discuss as a team to make progress labels May 6, 2024
@philwebb philwebb modified the milestones: General Backlog, 3.4.x May 6, 2024
@philwebb philwebb modified the milestones: 3.4.x, 3.5.x Jun 17, 2024
@philwebb philwebb added the theme: actuator Issues related to actuator and the management context label Jun 17, 2024
@philwebb philwebb modified the milestones: 3.5.x, 3.4.x Jun 17, 2024
@bclozel bclozel self-assigned this Jul 26, 2024
@bclozel bclozel modified the milestones: 3.4.x, 3.4.0-M2 Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: actuator Issues related to actuator and the management context type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

5 participants