-
Notifications
You must be signed in to change notification settings - Fork 41.2k
Migrate spring-boot-buildpack-platform to HttpClient 5 #33533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hey @scottfrederick I have raised PR #33649 for this. If you could, please take a look, and if the changes are sufficient, I can make the same for #33534. The PR #33649 uses mockito feature to mock final class ClosableHttpResponse I have tried those changes too, and you can find them here anugrahsinghal/spring-boot/gh-33533-no-final-mock if you would like to take a look. the changes are needed in
|
@anugrahsinghal I already have the changes for this and for #33534 completed, which is why I marked the issue as assigned to me. We want to wait until Spring Boot 3.1 to make these changes, and we haven't created the branches necessary to start work on 3.1 yet. |
apologies @scottfrederick Thanks for letting me know :) |
Apache HttpClient has been superseded by Apache HttpClient 5. The
spring-boot-buildpack-platform
module still uses HttpClient APIs, and should be migrated to the HttpClient 5 APIs.The text was updated successfully, but these errors were encountered: