Skip to content

Commit ca5bd37

Browse files
committed
Upgrade to Spring Framework 6.1.0-M1
Closes gh-35977 Closes gh-35980
1 parent 4dc0b26 commit ca5bd37

File tree

20 files changed

+78
-129
lines changed

20 files changed

+78
-129
lines changed

buildSrc/build.gradle

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,10 @@ new File(new File("$projectDir").parentFile, "gradle.properties").withInputStrea
1414
def properties = new Properties()
1515
properties.load(it)
1616
ext.set("kotlinVersion", properties["kotlinVersion"])
17-
ext.set("springFrameworkVersion", properties["springFrameworkVersion"])
18-
if (properties["springFrameworkVersion"].contains("-")) {
19-
repositories {
20-
maven { url "https://repo.spring.io/milestone" }
21-
maven { url "https://repo.spring.io/snapshot" }
22-
}
23-
}
2417
}
2518

19+
ext.set("springFrameworkVersion", "6.0.10")
20+
2621
sourceCompatibility = 17
2722
targetCompatibility = 17
2823

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ org.gradle.jvmargs=-Xmx2g -Dfile.encoding=UTF-8
66

77
kotlinVersion=1.8.22
88
nativeBuildToolsVersion=0.9.23
9-
springFrameworkVersion=6.0.10
9+
springFrameworkVersion=6.1.0-M1
1010
tomcatVersion=10.1.10
1111

1212
kotlin.stdlib.default.dependency=false

spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/observation/web/reactive/OrderedServerHttpObservationFilter.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
*
2929
* @author Moritz Halbritter
3030
*/
31+
@SuppressWarnings({ "deprecation", "removal" })
3132
class OrderedServerHttpObservationFilter extends ServerHttpObservationFilter implements OrderedWebFilter {
3233

3334
private final int order;

spring-boot-project/spring-boot-test/src/main/java/org/springframework/boot/test/web/client/TestRestTemplate.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1021,9 +1021,6 @@ public CustomHttpComponentsClientHttpRequestFactory(HttpClientOption[] httpClien
10211021
if (settings.connectTimeout() != null) {
10221022
setConnectTimeout((int) settings.connectTimeout().toMillis());
10231023
}
1024-
if (settings.bufferRequestBody() != null) {
1025-
setBufferRequestBody(settings.bufferRequestBody());
1026-
}
10271024
}
10281025

10291026
private HttpClient createHttpClient(Duration readTimeout, boolean ssl) {

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/context/SpringBootContextLoaderTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -255,7 +255,7 @@ private String[] getActiveProfiles(Class<?> testClass) {
255255
private Map<String, Object> getMergedContextConfigurationProperties(Class<?> testClass) {
256256
TestContext context = new ExposedTestContextManager(testClass).getExposedTestContext();
257257
MergedContextConfiguration config = (MergedContextConfiguration) ReflectionTestUtils.getField(context,
258-
"mergedContextConfiguration");
258+
"mergedConfig");
259259
return TestPropertySourceUtils.convertInlinedPropertiesToMap(config.getPropertySourceProperties());
260260
}
261261

spring-boot-project/spring-boot-test/src/test/java/org/springframework/boot/test/context/bootstrap/SpringBootTestContextBootstrapperTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ private TestContext buildTestContext(Class<?> testClass) {
110110
}
111111

112112
private MergedContextConfiguration getMergedContextConfiguration(TestContext context) {
113-
return (MergedContextConfiguration) ReflectionTestUtils.getField(context, "mergedContextConfiguration");
113+
return (MergedContextConfiguration) ReflectionTestUtils.getField(context, "mergedConfig");
114114
}
115115

116116
@SpringBootTest(webEnvironment = WebEnvironment.RANDOM_PORT)

spring-boot-project/spring-boot-tools/spring-boot-buildpack-platform/build.gradle

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@ configurations.all {
1414
if (dependency.requested.group.startsWith("com.fasterxml.jackson")) {
1515
dependency.useVersion("2.14.2")
1616
}
17+
// Downgrade Spring Framework as Gradle cannot cope with 6.1.0-M1's
18+
// multi-version jar files with bytecode in META-INF/versions/21
19+
if (dependency.requested.group.equals("org.springframework")) {
20+
dependency.useVersion("6.0.10")
21+
}
1722
}
1823
}
1924
}

spring-boot-project/spring-boot-tools/spring-boot-gradle-plugin/build.gradle

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,11 @@ configurations {
2323
if (dependency.requested.group.startsWith("com.fasterxml.jackson")) {
2424
dependency.useVersion("2.14.2")
2525
}
26+
// Downgrade Spring Framework as Gradle cannot cope with 6.1.0-M1's
27+
// multi-version jar files with bytecode in META-INF/versions/21
28+
if (dependency.requested.group.equals("org.springframework")) {
29+
dependency.useVersion("6.0.10")
30+
}
2631
}
2732
}
2833
}

spring-boot-project/spring-boot-tools/spring-boot-loader-tools/build.gradle

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,17 @@ configurations {
1717
extendsFrom dependencyManagement
1818
transitive = false
1919
}
20+
all {
21+
resolutionStrategy {
22+
eachDependency { dependency ->
23+
// Downgrade Spring Framework as Gradle cannot cope with 6.1.0-M1's
24+
// multi-version jar files with bytecode in META-INF/versions/21
25+
if (dependency.requested.group.equals("org.springframework")) {
26+
dependency.useVersion("6.0.10")
27+
}
28+
}
29+
}
30+
}
2031
}
2132

2233
dependencies {

spring-boot-project/spring-boot/src/main/java/org/springframework/boot/web/client/ClientHttpRequestFactories.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -151,7 +151,6 @@ static HttpComponentsClientHttpRequestFactory get(ClientHttpRequestFactorySettin
151151
settings.sslBundle());
152152
PropertyMapper map = PropertyMapper.get().alwaysApplyingWhenNonNull();
153153
map.from(settings::connectTimeout).asInt(Duration::toMillis).to(requestFactory::setConnectTimeout);
154-
map.from(settings::bufferRequestBody).to(requestFactory::setBufferRequestBody);
155154
return requestFactory;
156155
}
157156

@@ -187,8 +186,6 @@ private static HttpClient createHttpClient(Duration readTimeout, SslBundle sslBu
187186
static class OkHttp {
188187

189188
static OkHttp3ClientHttpRequestFactory get(ClientHttpRequestFactorySettings settings) {
190-
Assert.state(settings.bufferRequestBody() == null,
191-
() -> "OkHttp3ClientHttpRequestFactory does not support request body buffering");
192189
OkHttp3ClientHttpRequestFactory requestFactory = createRequestFactory(settings.sslBundle());
193190
PropertyMapper map = PropertyMapper.get().alwaysApplyingWhenNonNull();
194191
map.from(settings::connectTimeout).asInt(Duration::toMillis).to(requestFactory::setConnectTimeout);
@@ -227,7 +224,6 @@ static SimpleClientHttpRequestFactory get(ClientHttpRequestFactorySettings setti
227224
PropertyMapper map = PropertyMapper.get().alwaysApplyingWhenNonNull();
228225
map.from(settings::readTimeout).asInt(Duration::toMillis).to(requestFactory::setReadTimeout);
229226
map.from(settings::connectTimeout).asInt(Duration::toMillis).to(requestFactory::setConnectTimeout);
230-
map.from(settings::bufferRequestBody).to(requestFactory::setBufferRequestBody);
231227
return requestFactory;
232228
}
233229

@@ -274,8 +270,6 @@ private static void configure(ClientHttpRequestFactory requestFactory,
274270
PropertyMapper map = PropertyMapper.get().alwaysApplyingWhenNonNull();
275271
map.from(settings::connectTimeout).to((connectTimeout) -> setConnectTimeout(unwrapped, connectTimeout));
276272
map.from(settings::readTimeout).to((readTimeout) -> setReadTimeout(unwrapped, readTimeout));
277-
map.from(settings::bufferRequestBody)
278-
.to((bufferRequestBody) -> setBufferRequestBody(unwrapped, bufferRequestBody));
279273
}
280274

281275
private static ClientHttpRequestFactory unwrapRequestFactoryIfNecessary(
@@ -305,11 +299,6 @@ private static void setReadTimeout(ClientHttpRequestFactory factory, Duration re
305299
invoke(factory, method, timeout);
306300
}
307301

308-
private static void setBufferRequestBody(ClientHttpRequestFactory factory, boolean bufferRequestBody) {
309-
Method method = findMethod(factory, "setBufferRequestBody", boolean.class);
310-
invoke(factory, method, bufferRequestBody);
311-
}
312-
313302
private static Method findMethod(ClientHttpRequestFactory requestFactory, String methodName,
314303
Class<?>... parameters) {
315304
Method method = ReflectionUtils.findMethod(requestFactory.getClass(), methodName, parameters);

0 commit comments

Comments
 (0)