Skip to content
This repository was archived by the owner on Dec 17, 2021. It is now read-only.

Commit ed96f44

Browse files
authored
fix: default event formatting (#155)
* fix: default event formatting * fix: build fix * fix: build fix
1 parent 4602304 commit ed96f44

File tree

3 files changed

+25
-3
lines changed

3 files changed

+25
-3
lines changed

splunk_connect_for_snmp_poller/manager/poller.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@
3434
get_profiles,
3535
)
3636
from splunk_connect_for_snmp_poller.manager.tasks import snmp_polling
37+
from splunk_connect_for_snmp_poller.manager.validator.inventory_validator import (
38+
DYNAMIC_PROFILE,
39+
)
3740
from splunk_connect_for_snmp_poller.mongo import WalkedHostsRepository
3841
from splunk_connect_for_snmp_poller.utilities import (
3942
file_was_modified,
@@ -114,7 +117,7 @@ def __check_inventory(self):
114117
)
115118
continue
116119
inventory_hosts.add(entry_key)
117-
if ir.profile == "*":
120+
if ir.profile == DYNAMIC_PROFILE:
118121
self.delete_all_entries_per_host(ir.host)
119122
self.add_device_for_profile_matching(ir)
120123
else:

splunk_connect_for_snmp_poller/manager/poller_utilities.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
from splunk_connect_for_snmp_poller.manager.task_utilities import parse_port
2929
from splunk_connect_for_snmp_poller.manager.tasks import snmp_polling
3030
from splunk_connect_for_snmp_poller.manager.validator.inventory_validator import (
31+
DYNAMIC_PROFILE,
3132
is_valid_inventory_line_from_dict,
3233
should_process_inventory_line,
3334
)
@@ -75,7 +76,9 @@ def parse_inventory_file(inventory_file_path, profiles, fetch_frequency=True):
7576
agent["version"],
7677
agent["community"],
7778
agent["profile"],
78-
get_frequency(agent, profiles, 60) if fetch_frequency else None,
79+
get_frequency(agent, profiles, 60)
80+
if fetch_frequency and agent["profile"] != DYNAMIC_PROFILE
81+
else None,
7982
)
8083

8184

splunk_connect_for_snmp_poller/manager/task_utilities.py

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
)
4040
from splunk_connect_for_snmp_poller.manager.hec_sender import post_data_to_splunk_hec
4141
from splunk_connect_for_snmp_poller.manager.mib_server_client import get_translation
42+
from splunk_connect_for_snmp_poller.manager.realtime.interface_mib import InterfaceMib
4243
from splunk_connect_for_snmp_poller.manager.realtime.oid_constant import OidConstant
4344
from splunk_connect_for_snmp_poller.manager.static.interface_mib_utililities import (
4445
extract_network_interface_data_from_additional_config,
@@ -130,9 +131,24 @@ async def result_without_translation(var_binds):
130131
}
131132
result = json.dumps(result)
132133
else:
133-
result = '{{"metric": \'{{"{oid}":"{value}"}}\'}}'.format(
134+
metric_content_dict = {
135+
name.prettyPrint(): val.prettyPrint(),
136+
InterfaceMib.METRIC_NAME_KEY: name.prettyPrint(),
137+
}
138+
139+
metric_content = json.dumps(metric_content_dict)
140+
141+
non_metric_content = '{oid}="{value}"'.format(
134142
oid=name.prettyPrint(), value=val.prettyPrint()
135143
)
144+
145+
result_dict = {
146+
"metric": metric_content,
147+
"non_metric": non_metric_content,
148+
"metric_name": name.prettyPrint(),
149+
}
150+
151+
result = json.dumps(result_dict)
136152
logger.debug("Our result is_metric - %s and string - %s", is_metric, result)
137153
return is_metric, result
138154

0 commit comments

Comments
 (0)