feat: added unit tests (#37)

Author: weliasz

splunk_connect_for_snmp_poller/manager/task_utilities.py

@@ -63,7 +63,7 @@ def get_translated_string(mib_server_url, varBinds):
             f"Exception occurred while logging varBinds name & value. Exception: {e}"
         )
 
-    # Overrid the varBinds string with translated varBinds string
+    # Override the varBinds string with translated varBinds string
     try:
         result = get_translation(varBinds, mib_server_url, metric)
         logger.info(f"=========result=======\n{result}")
@@ -90,7 +90,7 @@ def mib_string_handler(
     """
     Perform the SNMP Get for mib-name/string,
     e.g. ['SNMPv2-MIB', 'sysUpTime',0] (syntax -> [<mib_file_name>, <mib_name/string>, <min_index>])
-    which querise the info correalted to this specific mib-name/string (e.g. sysUpTime)
+    which queries the info correlated to this specific mib-name/string (e.g. sysUpTime)
     """
     logger.info(
         f"Executing get_by_mib_name() with {host} {port} {version} {community} {mib_file} {mib_name} {mib_index} {mib_server_url}"
@@ -169,7 +169,7 @@ def walk_handler(snmp_engine, community, host, port, profile, mib_server_url, re
     """
     Perform the SNMP Walk for oid end with *,
     e.g. 1.3.6.1.2.1.1.9.*,
-    which queries the infos correalted to all the oids that underneath the prefix before the *, e.g. 1.3.6.1.2.1.1.9
+    which queries the infos correlated to all the oids that underneath the prefix before the *, e.g. 1.3.6.1.2.1.1.9
     """
     for (errorIndication, errorStatus, errorIndex, varBinds) in nextCmd(
         snmp_engine,

tests/test_task_utilities.py

@@ -0,0 +1,43 @@
+from unittest import TestCase
+
+from splunk_connect_for_snmp_poller.manager.task_utilities import is_metric_data, parse_port
+
+
+class ObjectTypeMock:
+
+    def __init__(self, value):
+        self._value = value
+
+    def prettyPrint(self):
+        return self._value
+
+
+class TestTaskUtilities(TestCase):
+    def test_metric_for_integer(self):
+        self.assertTrue(is_metric_data([('some_name', ObjectTypeMock('1'))]))
+
+    def test_metric_for_negative_integer(self):
+        self.assertTrue(is_metric_data([('some_name', ObjectTypeMock('-5'))]))
+
+    def test_metric_for_float(self):
+        self.assertTrue(is_metric_data([('some_name', ObjectTypeMock('2.0'))]))
+
+    def test_metric_for_negative_float(self):
+        self.assertTrue(is_metric_data([('some_name', ObjectTypeMock('-2.0'))]))
+
+    def test_metric_for_zero(self):
+        self.assertTrue(is_metric_data([('some_name', ObjectTypeMock('0'))]))
+
+    def test_metric_for_string(self):
+        self.assertFalse(is_metric_data([('some_name', ObjectTypeMock('asdad'))]))
+
+    def test_port_parse_with_default_port(self):
+        host, port = parse_port('192.168.0.13')
+        self.assertEqual(host, '192.168.0.13')
+        self.assertEqual(port, 161)
+
+    def test_port_parse_with_specified_port(self):
+        host, port = parse_port('192.168.0.13:765')
+        self.assertEqual(host, '192.168.0.13')
+        self.assertEqual(port, '765')
+