feat!: Use MONGO_URI (#70)

Ryan Faircloth · web-flow · commit 01949f3da512 · 2021-11-02T21:45:14.000-04:00
Allow use of Mongo with replica set by using the uri connection syntax
diff --git a/README.md b/README.md
@@ -52,8 +52,7 @@ cd "splunk-connect-for-snmp-mib-server"
 
 #### Setup Environment for Mib Server
 ```
-export MONGO_SERVICE_SERVICE_HOST=<mongo_host>
-export MONGO_SERVICE_SERVICE_PORT=<mongo_port>
+export MONGO_URI=mongodb://host:27017
 export MIBS_FILES_URL=http://0.0.0.0:5000/files/asn1/@mib@
 ```
 #### Install Poetry
diff --git a/poetry.lock b/poetry.lock
diff --git a/pyproject.toml b/pyproject.toml
@@ -22,7 +22,7 @@ license = "APACHE-2.0"
 
 [tool.poetry.dependencies]
 python = "^3.8"
-pymongo = "^3.11.3"
+pymongo = {version = "^3.11.3", extras = ["srv"]} 
 pysnmp = "^4.4.12"
 requests = "^2.25.1"
 PyYAML = "^5.4.1"
diff --git a/splunk_connect_for_snmp_mib_server/mongo.py b/splunk_connect_for_snmp_mib_server/mongo.py
@@ -25,10 +25,7 @@
 
 class MongoRepository:
     def __init__(self):
-        self._client = pymongo.MongoClient(
-            os.environ["MONGO_SERVICE_SERVICE_HOST"],
-            int(os.environ["MONGO_SERVICE_SERVICE_PORT"]),
-        )
+        self._client = pymongo.MongoClient(os.environ["MONGO_URI"])
         if os.environ.get("MONGO_USER"):
             self._client.admin.authenticate(
                 os.environ["MONGO_USER"],
diff --git a/tests/test_mongo.py b/tests/test_mongo.py
@@ -23,8 +23,6 @@
 
 def main():
     mongo_config = {
-        "host": "localhost",
-        "port": 27017,
         "database": "test",
         "collection": "mibs",
     }
diff --git a/tests/test_translator.py b/tests/test_translator.py
@@ -75,8 +75,7 @@ def setUpClass(cls):
             os.environ,
             {
                 "MIBS_FILES_URL": "http://0.0.0.0:5000/files/asn1/@mib@",
-                "MONGO_SERVICE_SERVICE_HOST": "localhost",
-                "MONGO_SERVICE_SERVICE_PORT": "27017",
+                "MONGO_URI": "mongodb://localhost:27017",
             },
         )
         cls.env_patcher.start()

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,6 @@`
`23`	`23`
`24`	`24`	`def main():`
`25`	`25`	`mongo_config = {`
`26`		`- "host": "localhost",`
`27`		`- "port": 27017,`
`28`	`26`	`"database": "test",`
`29`	`27`	`"collection": "mibs",`
`30`	`28`	`}`
Original file line number	Diff line number	Diff line change
`@@ -75,8 +75,7 @@ def setUpClass(cls):`
`75`	`75`	`os.environ,`
`76`	`76`	`{`
`77`	`77`	`"MIBS_FILES_URL": "http://0.0.0.0:5000/files/asn1/@mib@",`
`78`		`- "MONGO_SERVICE_SERVICE_HOST": "localhost",`
`79`		`- "MONGO_SERVICE_SERVICE_PORT": "27017",`
	`78`	`+ "MONGO_URI": "mongodb://localhost:27017",`
`80`	`79`	`},`
`81`	`80`	`)`
`82`	`81`	`cls.env_patcher.start()`