cleanup

sanzmauro · sanzmauro · commit ccf505ab44f4 · 2025-01-06T16:44:16.000-03:00
diff --git a/go.mod b/go.mod
@@ -3,7 +3,7 @@ module github.com/splitio/go-client/v6
 go 1.18
 
 require (
-	github.com/splitio/go-split-commons/v6 v6.0.3-0.20241230154236-0290e3993f69
+	github.com/splitio/go-split-commons/v6 v6.0.3-0.20250106193848-789eab2683d9
 	github.com/splitio/go-toolkit/v5 v5.4.0
 )
 
diff --git a/go.sum b/go.sum
@@ -18,6 +18,10 @@ github.com/splitio/go-split-commons/v6 v6.0.3-0.20241212182204-626e0eae79d0 h1:8
 github.com/splitio/go-split-commons/v6 v6.0.3-0.20241212182204-626e0eae79d0/go.mod h1:D/XIY/9Hmfk9ivWsRsJVp439kEdmHbzUi3PKzQQDOXY=
 github.com/splitio/go-split-commons/v6 v6.0.3-0.20241230154236-0290e3993f69 h1:6jmMkAAP0mHWFSju2b5UBr/IwwC5JD2yCLO2WbcK0nc=
 github.com/splitio/go-split-commons/v6 v6.0.3-0.20241230154236-0290e3993f69/go.mod h1:D/XIY/9Hmfk9ivWsRsJVp439kEdmHbzUi3PKzQQDOXY=
+github.com/splitio/go-split-commons/v6 v6.0.3-0.20250106193440-582d4aff769a h1:iK/6x7yQAbOrj3rbgXoUiBlBal2+zBPPT7c3iPRxLI0=
+github.com/splitio/go-split-commons/v6 v6.0.3-0.20250106193440-582d4aff769a/go.mod h1:D/XIY/9Hmfk9ivWsRsJVp439kEdmHbzUi3PKzQQDOXY=
+github.com/splitio/go-split-commons/v6 v6.0.3-0.20250106193848-789eab2683d9 h1:UvtXnoIddjx8KOgJ0GqAz/FL4UtkfNyfElM4rz04GgM=
+github.com/splitio/go-split-commons/v6 v6.0.3-0.20250106193848-789eab2683d9/go.mod h1:D/XIY/9Hmfk9ivWsRsJVp439kEdmHbzUi3PKzQQDOXY=
 github.com/splitio/go-toolkit/v5 v5.4.0 h1:g5WFpRhQomnXCmvfsNOWV4s5AuUrWIZ+amM68G8NBKM=
 github.com/splitio/go-toolkit/v5 v5.4.0/go.mod h1:xYhUvV1gga9/1029Wbp5pjnR6Cy8nvBpjw99wAbsMko=
 github.com/stretchr/objx v0.5.2 h1:xuMeJ0Sdp5ZMRXx/aWO6RZxdr3beISkG5/G/aIRr3pY=
diff --git a/splitio/impressions/builder.go b/splitio/impressions/builder.go
@@ -53,8 +53,8 @@ func BuildInMemoryManager(
 	noneStrategy := strategy.NewNoneImpl(impressionsCounter, uniqueKeysTracker, listenerEnabled)
 
 	if cfg.ImpressionsMode == config.ImpressionsModeNone {
-		impManager := provisional.NewImpressionManager(noneStrategy)
-		return impManager.(*provisional.ImpressionManagerImpl), nil
+		impManager := provisional.NewImpressionManagerImp(noneStrategy, nil)
+		return impManager, nil
 	}
 
 	workers.ImpressionRecorder = impression.NewRecorderSingle(impressionStorage, splitAPI.ImpressionRecorder, logger, metadata, cfg.ImpressionsMode, telemetryStorage)
@@ -73,8 +73,7 @@ func BuildInMemoryManager(
 		impressionsStrategy = strategy.NewOptimizedImpl(impressionObserver, impressionsCounter, telemetryStorage, listenerEnabled)
 	}
 
-	manager := provisional.NewImpressionManager(impressionsStrategy).(*provisional.ImpressionManagerImpl)
-	manager.SetNoneStrategy(noneStrategy)
+	manager := provisional.NewImpressionManagerImp(noneStrategy, impressionsStrategy)
 
 	return manager, nil
 }
@@ -103,8 +102,8 @@ func BuildRedisManager(
 	noneStrategy := strategy.NewNoneImpl(impressionsCounter, uniqueKeysTracker, listenerEnabled)
 
 	if cfg.ImpressionsMode == config.ImpressionsModeNone {
-		impManager := provisional.NewImpressionManager(noneStrategy)
-		return impManager.(*provisional.ImpressionManagerImpl), nil
+		impManager := provisional.NewImpressionManagerImp(noneStrategy, nil)
+		return impManager, nil
 	}
 
 	impressionObserver, err := strategy.NewImpressionObserver(500)
@@ -120,8 +119,7 @@ func BuildRedisManager(
 		impressionsStrategy = strategy.NewOptimizedImpl(impressionObserver, impressionsCounter, telemetryRuntimeStorage, listenerEnabled)
 	}
 
-	manager := provisional.NewImpressionManager(impressionsStrategy).(*provisional.ImpressionManagerImpl)
-	manager.SetNoneStrategy(noneStrategy)
+	manager := provisional.NewImpressionManagerImp(noneStrategy, impressionsStrategy)
 
 	return manager, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ module github.com/splitio/go-client/v6`
`3`	`3`	`go 1.18`
`4`	`4`
`5`	`5`	`require (`
`6`		`- github.com/splitio/go-split-commons/v6 v6.0.3-0.20241230154236-0290e3993f69`
	`6`	`+ github.com/splitio/go-split-commons/v6 v6.0.3-0.20250106193848-789eab2683d9`
`7`	`7`	`github.com/splitio/go-toolkit/v5 v5.4.0`
`8`	`8`	`)`
`9`	`9`
Original file line number	Diff line number	Diff line change
`@@ -53,8 +53,8 @@ func BuildInMemoryManager(`
`53`	`53`	`noneStrategy := strategy.NewNoneImpl(impressionsCounter, uniqueKeysTracker, listenerEnabled)`
`54`	`54`
`55`	`55`	`if cfg.ImpressionsMode == config.ImpressionsModeNone {`
`56`		`- impManager := provisional.NewImpressionManager(noneStrategy)`
`57`		`- return impManager.(*provisional.ImpressionManagerImpl), nil`
	`56`	`+ impManager := provisional.NewImpressionManagerImp(noneStrategy, nil)`
	`57`	`+ return impManager, nil`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`workers.ImpressionRecorder = impression.NewRecorderSingle(impressionStorage, splitAPI.ImpressionRecorder, logger, metadata, cfg.ImpressionsMode, telemetryStorage)`
`@@ -73,8 +73,7 @@ func BuildInMemoryManager(`
`73`	`73`	`impressionsStrategy = strategy.NewOptimizedImpl(impressionObserver, impressionsCounter, telemetryStorage, listenerEnabled)`
`74`	`74`	`}`
`75`	`75`
`76`		`- manager := provisional.NewImpressionManager(impressionsStrategy).(*provisional.ImpressionManagerImpl)`
`77`		`- manager.SetNoneStrategy(noneStrategy)`
	`76`	`+ manager := provisional.NewImpressionManagerImp(noneStrategy, impressionsStrategy)`
`78`	`77`
`79`	`78`	`return manager, nil`
`80`	`79`	`}`
`@@ -103,8 +102,8 @@ func BuildRedisManager(`
`103`	`102`	`noneStrategy := strategy.NewNoneImpl(impressionsCounter, uniqueKeysTracker, listenerEnabled)`
`104`	`103`
`105`	`104`	`if cfg.ImpressionsMode == config.ImpressionsModeNone {`
`106`		`- impManager := provisional.NewImpressionManager(noneStrategy)`
`107`		`- return impManager.(*provisional.ImpressionManagerImpl), nil`
	`105`	`+ impManager := provisional.NewImpressionManagerImp(noneStrategy, nil)`
	`106`	`+ return impManager, nil`
`108`	`107`	`}`
`109`	`108`
`110`	`109`	`impressionObserver, err := strategy.NewImpressionObserver(500)`
`@@ -120,8 +119,7 @@ func BuildRedisManager(`
`120`	`119`	`impressionsStrategy = strategy.NewOptimizedImpl(impressionObserver, impressionsCounter, telemetryRuntimeStorage, listenerEnabled)`
`121`	`120`	`}`
`122`	`121`
`123`		`- manager := provisional.NewImpressionManager(impressionsStrategy).(*provisional.ImpressionManagerImpl)`
`124`		`- manager.SetNoneStrategy(noneStrategy)`
	`122`	`+ manager := provisional.NewImpressionManagerImp(noneStrategy, impressionsStrategy)`
`125`	`123`
`126`	`124`	`return manager, nil`
`127`	`125`	`}`