Skip to content

Commit 051c611

Browse files
committed
resource naming enhancement and bug fix
1 parent 691d5f2 commit 051c611

File tree

5 files changed

+10
-13
lines changed

5 files changed

+10
-13
lines changed

sebs/aws/aws.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,12 +393,13 @@ def default_function_name(
393393
self,code_package: Benchmark, resources: Optional[Resources] = None
394394
) -> str:
395395
# Create function name
396+
resource_id = resources.resources_id if resources else self.config.resources.resources_id
396397
func_name = "{}-{}-{}-{}-{}".format(
398+
resource_id,
397399
code_package.benchmark,
398400
code_package.language_name,
399401
code_package.language_version,
400402
code_package.architecture,
401-
self.config.resources.resources_id,
402403
)
403404
if code_package.container_deployment:
404405
func_name = f"{func_name}-docker"

sebs/azure/azure.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -331,10 +331,10 @@ def default_function_name(
331331
"""
332332
func_name = (
333333
"{}-{}-{}-{}".format(
334+
self.config.resources.resources_id,
334335
code_package.benchmark,
335336
code_package.language_name,
336337
code_package.language_version,
337-
self.config.resources.resources_id,
338338
)
339339
.replace(".", "-")
340340
.replace("_", "-")

sebs/gcp/gcp.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,11 +108,12 @@ def default_function_name(
108108
self,code_package: Benchmark, resources: Optional[Resources] = None
109109
) -> str:
110110
# Create function name
111+
resource_id = resources.resources_id if resources else self.config.resources.resources_id
111112
func_name = "{}-{}-{}-{}".format(
113+
resource_id,
112114
code_package.benchmark,
113115
code_package.language_name,
114116
code_package.language_version,
115-
self.config.resources.resources_id,
116117
)
117118
return GCP.format_function_name(func_name)
118119

sebs/local/local.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -348,10 +348,10 @@ def default_function_name(
348348
# Create function name
349349
if resources is not None:
350350
func_name = "{}-{}-{}-{}".format(
351+
resources.resources_id,
351352
code_package.benchmark,
352353
code_package.language_name,
353354
code_package.language_version,
354-
resources.resources_id,
355355
)
356356
else:
357357
func_name = "{}-{}-{}".format(

sebs/openwhisk/openwhisk.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -325,16 +325,11 @@ def is_configuration_changed(self, cached_function: Function, benchmark: Benchma
325325
def default_function_name(
326326
self, code_package: Benchmark, resources: Optional[Resources] = None
327327
) -> str:
328-
if resources is not None:
329-
return (
330-
f"{code_package.benchmark}-{code_package.language_name}-"
331-
f"{code_package.language_version}-{resources.resources_id}"
332-
)
328+
resource_id = resources.resources_id if resources else self.config.resources.resources_id
333329
return (
334-
f"{code_package.benchmark}-{code_package.language_name}-"
335-
f"{code_package.language_version}"
336-
)
337-
330+
f"{resource_id}-{code_package.benchmark}-"
331+
f"{code_package.language_name}-{code_package.language_version}"
332+
)
338333
def enforce_cold_start(self, functions: List[Function], code_package: Benchmark):
339334
raise NotImplementedError()
340335

0 commit comments

Comments
 (0)