Skip to content

Commit 327977f

Browse files
authored
Merge pull request #34 from sourcetoad/min-max-size-type-fix
Fixed allowed types on integer comparison rules
2 parents 7fd3103 + df2730b commit 327977f

File tree

3 files changed

+287
-33
lines changed

3 files changed

+287
-33
lines changed

src/Rule.php

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -477,19 +477,19 @@ public static function filled(): string
477477
*
478478
* @link https://laravel.com/docs/10.x/validation#rule-gt
479479
*/
480-
public static function gt(string $field): string
480+
public static function gt(BigNumber|int|float|string $field): string
481481
{
482-
return 'gt:'.$field;
482+
return sprintf('gt:%s', $field);
483483
}
484484

485485
/**
486486
* The field under validation must be greater than or equal to the given *field*.
487487
*
488488
* @link https://laravel.com/docs/10.x/validation#rule-gte
489489
*/
490-
public static function gte(string $field): string
490+
public static function gte(BigNumber|int|float|string $field): string
491491
{
492-
return 'gte:'.$field;
492+
return sprintf('gte:%s', $field);
493493
}
494494

495495
/**
@@ -593,19 +593,19 @@ public static function lowercase(): string
593593
*
594594
* @link https://laravel.com/docs/10.x/validation#rule-lt
595595
*/
596-
public static function lt(string $field): string
596+
public static function lt(BigNumber|int|float|string $field): string
597597
{
598-
return 'lt:'.$field;
598+
return sprintf('lt:%s', $field);
599599
}
600600

601601
/**
602602
* The field under validation must be less than or equal to the given *field*.
603603
*
604604
* @link https://laravel.com/docs/10.x/validation#rule-lte
605605
*/
606-
public static function lte(string $field): string
606+
public static function lte(BigNumber|int|float|string $field): string
607607
{
608-
return 'lte:'.$field;
608+
return sprintf('lte:%s', $field);
609609
}
610610

611611
/**
@@ -623,9 +623,9 @@ public static function macAddress(): string
623623
*
624624
* @link https://laravel.com/docs/10.x/validation#rule-max
625625
*/
626-
public static function max(int $value): string
626+
public static function max(BigNumber|int|float|string $value): string
627627
{
628-
return 'max:'.$value;
628+
return sprintf('max:%s', $value);
629629
}
630630

631631
/**
@@ -664,9 +664,9 @@ public static function mimetypes(string ...$mimeType): string
664664
*
665665
* @link https://laravel.com/docs/10.x/validation#rule-min
666666
*/
667-
public static function min(int $value): string
667+
public static function min(BigNumber|int|float|string $value): string
668668
{
669-
return 'min:'.$value;
669+
return sprintf('min:%s', $value);
670670
}
671671

672672
/**
@@ -1007,9 +1007,9 @@ public static function same(string $field): string
10071007
*
10081008
* @link https://laravel.com/docs/10.x/validation#rule-size
10091009
*/
1010-
public static function size(int $value): string
1010+
public static function size(BigNumber|int|float|string $value): string
10111011
{
1012-
return 'size:'.$value;
1012+
return sprintf('size:%s', $value);
10131013
}
10141014

10151015
/**

src/RuleSet.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -536,7 +536,7 @@ public function filled(): self
536536
*
537537
* @link https://laravel.com/docs/10.x/validation#rule-gt
538538
*/
539-
public function gt(string $field): self
539+
public function gt(BigNumber|int|float|string $field): self
540540
{
541541
return $this->rule(Rule::gt($field));
542542
}
@@ -546,7 +546,7 @@ public function gt(string $field): self
546546
*
547547
* @link https://laravel.com/docs/10.x/validation#rule-gte
548548
*/
549-
public function gte(string $field): self
549+
public function gte(BigNumber|int|float|string $field): self
550550
{
551551
return $this->rule(Rule::gte($field));
552552
}
@@ -652,7 +652,7 @@ public function lowercase(): self
652652
*
653653
* @link https://laravel.com/docs/10.x/validation#rule-lt
654654
*/
655-
public function lt(string $field): self
655+
public function lt(BigNumber|int|float|string $field): self
656656
{
657657
return $this->rule(Rule::lt($field));
658658
}
@@ -662,7 +662,7 @@ public function lt(string $field): self
662662
*
663663
* @link https://laravel.com/docs/10.x/validation#rule-lte
664664
*/
665-
public function lte(string $field): self
665+
public function lte(BigNumber|int|float|string $field): self
666666
{
667667
return $this->rule(Rule::lte($field));
668668
}
@@ -682,7 +682,7 @@ public function macAddress(): self
682682
*
683683
* @link https://laravel.com/docs/10.x/validation#rule-max
684684
*/
685-
public function max(int $value): self
685+
public function max(BigNumber|int|float|string $value): self
686686
{
687687
return $this->rule(Rule::max($value));
688688
}
@@ -723,7 +723,7 @@ public function mimetypes(string ...$mimeType): self
723723
*
724724
* @link https://laravel.com/docs/10.x/validation#rule-min
725725
*/
726-
public function min(int $value): self
726+
public function min(BigNumber|int|float|string $value): self
727727
{
728728
return $this->rule(Rule::min($value));
729729
}
@@ -1069,7 +1069,7 @@ public function same(string $field): self
10691069
*
10701070
* @link https://laravel.com/docs/10.x/validation#rule-size
10711071
*/
1072-
public function size(int $value): self
1072+
public function size(BigNumber|int|float|string $value): self
10731073
{
10741074
return $this->rule(Rule::size($value));
10751075
}

0 commit comments

Comments
 (0)