Skip to content

Integrate 1920 Source Format, Add Prepend Editor, Add Autograding Tab #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
May 21, 2019

Conversation

geshuming
Copy link
Contributor

@geshuming geshuming commented Apr 11, 2019

  • Added new fields to IQuestion:
    • Prepend
    • Postpend
    • Testcases: which are of ITestcase
  • Added new tab to assessmentWorkspace for users to run their code against specific test cases
    autogradertest

Todo:

  • Improve overall UI/UX elements
  • Add new tab to gradingWorkspace
  • Add autograding results from backend
  • Add tests
  • Update Mission Control to export new xml format and allow editing of new fields

@coveralls
Copy link

coveralls commented Apr 11, 2019

Pull Request Test Coverage Report for Build 1610

  • 34 of 111 (30.63%) changed or added relevant lines in 16 files are covered.
  • 67 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.06%) to 24.353%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/actions/interpreter.ts 1 2 50.0%
src/actions/workspaces.ts 2 3 66.67%
src/components/assessment/AssessmentWorkspace.tsx 5 6 83.33%
src/containers/PlaygroundContainer.ts 0 1 0.0%
src/containers/academy/grading/GradingWorkspaceContainer.ts 0 1 0.0%
src/containers/missionControl/EditingWorkspaceContainer.ts 0 1 0.0%
src/components/missionControl/xmlParseHelper.ts 1 3 33.33%
src/components/workspace/side-content/Autograder.tsx 3 5 60.0%
src/containers/assessment/AssessmentWorkspaceContainer.ts 0 2 0.0%
src/components/workspace/EditorPrepend.tsx 8 11 72.73%
Files with Coverage Reduction New Missed Lines %
src/components/workspace/index.tsx 1 15.0%
src/containers/PlaygroundContainer.ts 1 28.13%
src/components/Playground.tsx 3 85.71%
src/utils/slangHelper.ts 5 22.5%
src/sagas/index.ts 8 14.9%
src/components/workspace/ControlBar.tsx 49 11.17%
Totals Coverage Status
Change from base Build 1487: 0.06%
Covered Lines: 1208
Relevant Lines: 4136

💛 - Coveralls

@geshuming geshuming requested a review from yyc April 11, 2019 08:31
@geshuming geshuming changed the title Integrate new XML format and add Autograding Tab Integrate 1920 Source Format and Add Autograding tab May 16, 2019
Copy link
Contributor

@yyc yyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, keep me updated on the new additions :)

@geshuming
Copy link
Contributor Author

In addition to above, I have added a resizable read-only editor to view/copy prepend code.

@geshuming geshuming closed this May 17, 2019
@geshuming
Copy link
Contributor Author

autogradertest

@geshuming geshuming reopened this May 17, 2019
@geshuming geshuming changed the title Integrate 1920 Source Format and Add Autograding tab Integrate 1920 Source Format, Add Prepend Editor, Add Autograding Tab May 21, 2019
@geshuming geshuming merged commit 4170ff7 into source-academy:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants