revert vite alignment until we know more, add server option to types

Author: ryansolid

.changeset/tiny-crews-work.md

@@ -0,0 +1,5 @@
+---
+"@solidjs/start": patch
+---
+
+revert vite alignment until we know more, add server option to types

docs/routes/api/app-config.md

@@ -51,16 +51,16 @@ export default defineConfig({
 });
 ```
 
-The `vite` option can also be a function which can be customized for each Vinxi environment. In SolidStart we use 3, `server` for SSR, `client` for the browser, and `server-function` for server functions.
+The `vite` option can also be a function which can be customized for each Vinxi router. In SolidStart we use 3, `server` for SSR, `client` for the browser, and `server-function` for server functions.
 
 ```tsx
 import { defineConfig } from "@solidjs/start/config";
 
 export default defineConfig({
-  vite({ enviroment }) {
-    if (enviroment === "server") {
-    } else if (enviroment === "client") {
-    } else if (enviroment === "server-function") {
+  vite({ router }) {
+    if (router === "server") {
+    } else if (router === "client") {
+    } else if (router === "server-function") {
     }
     return { plugins: [] };
   }

packages/start/config/index.d.ts

@@ -1,7 +1,13 @@
 import type { AppOptions } from "vinxi";
 import type { CustomizableConfig } from "vinxi/dist/types/lib/vite-dev";
+import { InlineConfig } from "vite";
 import type { Options } from "vite-plugin-solid";
 
+// atleast until we sort which server options are good to use
+type ViteCustomizableConfig = CustomizableConfig & {
+  server?: InlineConfig["server"];
+}
+
 type SolidStartInlineConfig = {
   ssr?: boolean;
   solid?: Options;
@@ -15,8 +21,8 @@ type SolidStartInlineConfig = {
     islands?: boolean;
   }
   vite?:
-    | CustomizableConfig
-    | ((options: { environment: "server" | "client" | "server-function" }) => CustomizableConfig);
+    | ViteCustomizableConfig
+    | ((options: { router: "server" | "client" | "server-function" }) => ViteCustomizableConfig);
 };
 
 export declare function defineConfig(baseConfig?: SolidStartInlineConfig): any;

packages/start/config/index.js

@@ -91,7 +91,7 @@ export function defineConfig(baseConfig = {}) {
         extensions,
         target: "server",
         plugins: async () => {
-          const userConfig = typeof vite === "function" ? await vite({ environment: "server" }) : { ...vite };
+          const userConfig = typeof vite === "function" ? await vite({ router: "server" }) : { ...vite };
           const plugins = userConfig.plugins || [];
           delete userConfig.plugins;
           return [
@@ -150,7 +150,7 @@ export function defineConfig(baseConfig = {}) {
         extensions,
         target: "browser",
         plugins: async () => {
-          const userConfig = typeof vite === "function" ? await vite({ environment: "client" }) : { ...vite };
+          const userConfig = typeof vite === "function" ? await vite({ router: "client" }) : { ...vite };
           const plugins = userConfig.plugins || [];
           delete userConfig.plugins;
           return [
@@ -212,7 +212,7 @@ export function defineConfig(baseConfig = {}) {
         target: "server",
         routes: solidStartServerFsRouter({ dir: routeDir, extensions }),
         plugins: async () => {
-          const userConfig = typeof vite === "function" ? await vite({ environment: "server-function" }) : { ...vite };
+          const userConfig = typeof vite === "function" ? await vite({ router: "server-function" }) : { ...vite };
           const plugins = userConfig.plugins || [];
           delete userConfig.plugins;
           return [