fix: move getServerFunctionMeta export to @solidjs/start (#1773)

Author: katywings

.changeset/metal-ladybugs-check.md

@@ -0,0 +1,7 @@
+---
+"@solidjs/start": patch
+---
+
+Move `getServerFunctionMeta` from `@solidjs/start/server` to `@solidjs/start` to fix circular import issues.
+
+The old export at `@solidjs/start/server` still exists, but is **deprecated** and will be removed in a future release.

.gitignore

@@ -26,6 +26,7 @@ node_modules
 
 .tmp
 test/playwright-report
+tests/server-function/cypress/screenshots
 
 # Temp
 gitignore

packages/start/src/index.tsx

@@ -1,6 +1,6 @@
 // @refresh skip
+export { default as clientOnly } from "./shared/clientOnly";
 export { GET } from "./shared/GET";
 export { HttpHeader } from "./shared/HttpHeader";
 export { HttpStatusCode } from "./shared/HttpStatusCode";
-export { default as clientOnly } from "./shared/clientOnly";
-
+export { getServerFunctionMeta } from "./shared/serverFunction";

packages/start/src/server/index.tsx

@@ -1,9 +1,11 @@
 // @refresh skip
-export { StartServer } from "./StartServer";
 export { createHandler } from "./handler";
-export { getServerFunctionMeta } from "./serverFunction";
+export { StartServer } from "./StartServer";
 export type {
   APIEvent,
   APIHandler, Asset, ContextMatches, DocumentComponentProps, FetchEvent, HandlerOptions, PageEvent, ResponseStub, ServerFunctionMeta
 } from "./types";
+import { getServerFunctionMeta as getServerFunctionMeta_ } from "../shared/serverFunction";
 
+/** @deprecated */
+export const getServerFunctionMeta = getServerFunctionMeta_;

packages/start/src/server/serverFunction.tsx renamed to packages/start/src/shared/serverFunction.tsx

@@ -1,5 +1,5 @@
 import { getRequestEvent } from "solid-js/web";
-import type { ServerFunctionMeta } from "./types";
+import type { ServerFunctionMeta } from "../server/types";
 
 /**
  *

tests/server-function/cypress/e2e/server-function.cy.ts

@@ -7,6 +7,10 @@ describe("server-function", () => {
     cy.visit("/is-server-nested");
     cy.get("#server-fn-test").contains('{"serverFnWithIsServer":true}');
   })
+  it("should have an id of type string in the server function meta - nested", () => {
+    cy.visit("/server-function-meta-nested");
+    cy.get("#server-fn-test").contains('{"serverFnWithMeta":"string"}');
+  })
   it("should externalize node builtin in server function - nested", () => {
     cy.visit("/node-builtin-nested");
     cy.get("#server-fn-test").contains('{"serverFnWithNodeBuiltin":"can/externalize"}');
@@ -20,6 +24,10 @@ describe("server-function", () => {
     cy.visit("/is-server-toplevel");
     cy.get("#server-fn-test").contains('{"serverFnWithIsServer":true}');
   })
+  it("should have an id of type string in the server function meta - toplevel", () => {
+    cy.visit("/server-function-meta");
+    cy.get("#server-fn-test").contains('{"serverFnWithMeta":"string"}');
+  })
   it("should externalize node builtin in server function - toplevel", () => {
     cy.visit("/node-builtin-toplevel");
     cy.get("#server-fn-test").contains('{"serverFnWithNodeBuiltin":"can/externalize"}');

tests/server-function/src/functions/use-server-function-meta.ts

@@ -0,0 +1,7 @@
+"use server";
+
+import { getServerFunctionMeta } from "@solidjs/start";
+
+export function serverFnWithMeta() {
+  return typeof getServerFunctionMeta()?.id;
+}

tests/server-function/src/routes/server-function-meta-nested.tsx

@@ -0,0 +1,23 @@
+import { getServerFunctionMeta } from "@solidjs/start";
+import { createEffect, createSignal } from "solid-js";
+
+function serverFnWithMeta() {
+  "use server";
+
+  return typeof getServerFunctionMeta()?.id;
+}
+
+export default function App() {
+  const [output, setOutput] = createSignal<{ serverFnWithMeta?: string }>({});
+
+  createEffect(async () => {
+    const result = await serverFnWithMeta();
+    setOutput(prev => ({ ...prev, serverFnWithMeta: result }));
+  });
+
+  return (
+    <main>
+      <span id="server-fn-test">{JSON.stringify(output())}</span>
+    </main>
+  );
+}

tests/server-function/src/routes/server-function-meta.tsx

@@ -0,0 +1,17 @@
+import { createEffect, createSignal } from "solid-js";
+import { serverFnWithMeta } from "~/functions/use-server-function-meta";
+
+export default function App() {
+  const [output, setOutput] = createSignal<{ serverFnWithMeta?: string }>({});
+
+  createEffect(async () => {
+    const result = await serverFnWithMeta();
+    setOutput(prev => ({ ...prev, serverFnWithMeta: result }));
+  });
+
+  return (
+    <main>
+      <span id="server-fn-test">{JSON.stringify(output())}</span>
+    </main>
+  );
+}