chore(Worklets): remove runtime-string association from RuntimeManager (#8443)

## Summary

I'm removing the association of runtime name - worklet runtime from
runtime manager. It was added as a possibility for future extension but
since the names of the runtimes don't have to be unique and there are
already unique IDs for the runtimes, the association is obsolete.

It's safe to delete it since it's not used and it's a private API.

## Test plan

CI

Author: tjzel

packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/RuntimeData.cpp

@@ -1,3 +1,9 @@
 #include <worklets/WorkletRuntime/RuntimeData.h>
 
+namespace worklets {
+namespace RuntimeData {
+
 const std::string uiRuntimeName{"UI"};
+
+} // namespace RuntimeData
+} // namespace worklets

packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/RuntimeData.h

@@ -2,9 +2,15 @@
 
 #include <string>
 
+namespace worklets {
+namespace RuntimeData {
+
 /**
  * Unused, but kept for possible future use.
  */
 constexpr uint64_t rnRuntimeId{0};
 constexpr uint64_t uiRuntimeId{1};
 extern const std::string uiRuntimeName;
+
+}; // namespace RuntimeData
+} // namespace worklets

packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/RuntimeManager.cpp

@@ -13,15 +13,6 @@ std::shared_ptr<WorkletRuntime> RuntimeManager::getRuntime(uint64_t runtimeId) {
   return nullptr;
 }
 
-std::shared_ptr<WorkletRuntime> RuntimeManager::getRuntime(
-    const std::string &name) {
-  std::shared_lock lock(weakRuntimesMutex_);
-  if (nameToRuntimeId_.contains(name)) {
-    return getRuntime(nameToRuntimeId_.at(name));
-  }
-  return nullptr;
-}
-
 #ifdef WORKLETS_BUNDLE_MODE
 std::shared_ptr<WorkletRuntime> RuntimeManager::getRuntime(
     jsi::Runtime *runtime) {
@@ -49,7 +40,7 @@ std::vector<std::shared_ptr<WorkletRuntime>> RuntimeManager::getAllRuntimes() {
 }
 
 std::shared_ptr<WorkletRuntime> RuntimeManager::getUIRuntime() {
-  return getRuntime(uiRuntimeId);
+  return getRuntime(RuntimeData::uiRuntimeId);
 }
 
 std::shared_ptr<WorkletRuntime> RuntimeManager::createWorkletRuntime(
@@ -70,7 +61,7 @@ std::shared_ptr<WorkletRuntime> RuntimeManager::createWorkletRuntime(
     workletRuntime->runGuarded(initializer);
   }
 
-  registerRuntime(runtimeId, name, workletRuntime);
+  registerRuntime(runtimeId, workletRuntime);
 
   return workletRuntime;
 }
@@ -79,9 +70,13 @@ std::shared_ptr<WorkletRuntime> RuntimeManager::createUninitializedUIRuntime(
     const std::shared_ptr<MessageQueueThread> &jsQueue,
     const std::shared_ptr<AsyncQueue> &uiAsyncQueue) {
   const auto uiRuntime = std::make_shared<WorkletRuntime>(
-      uiRuntimeId, jsQueue, uiRuntimeName, uiAsyncQueue);
+      RuntimeData::uiRuntimeId,
+      jsQueue,
+      RuntimeData::uiRuntimeName,
+      uiAsyncQueue,
+      /*enableEventLoop*/ false);
 
-  registerRuntime(uiRuntimeId, uiRuntimeName, uiRuntime);
+  registerRuntime(RuntimeData::uiRuntimeId, uiRuntime);
 
   return uiRuntime;
 }
@@ -92,11 +87,9 @@ uint64_t RuntimeManager::getNextRuntimeId() {
 
 void RuntimeManager::registerRuntime(
     const uint64_t runtimeId,
-    const std::string &name,
     const std::shared_ptr<WorkletRuntime> &workletRuntime) {
   std::unique_lock lock(weakRuntimesMutex_);
   weakRuntimes_[runtimeId] = workletRuntime;
-  nameToRuntimeId_[name] = runtimeId;
 #ifdef WORKLETS_BUNDLE_MODE
   runtimeAddressToRuntimeId_[&workletRuntime->getJSIRuntime()] = runtimeId;
 #endif // WORKLETS_BUNDLE_MODE

packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/RuntimeManager.h

@@ -23,7 +23,6 @@ class JSIWorkletsModuleProxy;
 class RuntimeManager {
  public:
   std::shared_ptr<WorkletRuntime> getRuntime(uint64_t runtimeId);
-  std::shared_ptr<WorkletRuntime> getRuntime(const std::string &name);
 #ifdef WORKLETS_BUNDLE_MODE
   std::shared_ptr<WorkletRuntime> getRuntime(jsi::Runtime *runtime);
 #endif // WORKLETS_BUNDLE_MODE
@@ -48,13 +47,11 @@ class RuntimeManager {
 
   void registerRuntime(
       const uint64_t runtimeId,
-      const std::string &name,
       const std::shared_ptr<WorkletRuntime> &workletRuntime);
 
-  std::atomic_uint64_t nextRuntimeId_{uiRuntimeId + 1};
+  std::atomic_uint64_t nextRuntimeId_{RuntimeData::uiRuntimeId + 1};
   std::map<uint64_t, std::weak_ptr<WorkletRuntime>> weakRuntimes_;
   std::shared_mutex weakRuntimesMutex_;
-  std::map<std::string, uint64_t> nameToRuntimeId_;
 #ifdef WORKLETS_BUNDLE_MODE
   std::map<jsi::Runtime *, uint64_t> runtimeAddressToRuntimeId_;
 #endif // WORKLETS_BUNDLE_MODE

packages/react-native-worklets/Common/cpp/worklets/WorkletRuntime/WorkletRuntime.cpp

@@ -81,7 +81,7 @@ WorkletRuntime::WorkletRuntime(
       queue_(queue) {
   jsi::Runtime &rt = *runtime_;
   WorkletRuntimeCollector::install(rt);
-  if (enableEventLoop && name != uiRuntimeName) {
+  if (enableEventLoop) {
     eventLoop_ = std::make_shared<EventLoop>(name_, runtime_, queue_);
     eventLoop_->run();
   }