fix(boost): use atomic AddInt32 to modify wait group counter (#91)

plastikfan · plastikfan · commit 18e69a1742ec · 2023-11-02T19:26:28.000Z
diff --git a/.github/workflows/ci-workflow.yml b/.github/workflows/ci-workflow.yml
@@ -14,7 +14,7 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.52.2
+          version: v1.54.2
           args: --verbose
 
   test:
diff --git a/.golangci.yml b/.golangci.yml
@@ -64,3 +64,4 @@ linters:
 
 run:
   issues-exit-code: 1
+  timeout: 5m
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -7,6 +7,7 @@
     "Assistable",
     "bodyclose",
     "coverpkg",
+    "coverprofile",
     "cubiest",
     "deadcode",
     "depguard",
@@ -24,27 +25,33 @@
     "gocyclo",
     "gofmt",
     "goimports",
+    "golangci",
     "goleak",
     "gomnd",
     "gosec",
     "gosimple",
+    "goveralls",
     "govet",
     "graffico",
     "ineffassign",
     "jibberjabber",
     "leaktest",
     "linters",
     "lorax",
+    "mattn",
     "nakedret",
     "nolint",
     "nolintlint",
+    "onsi",
     "passthru",
     "pixa",
     "prealloc",
     "repotoken",
+    "shogo",
     "sidewalk",
     "skeletor",
     "smaug",
+    "snivilised",
     "staticcheck",
     "structcheck",
     "stylecheck",
diff --git a/boost/annotated-wait-group.go b/boost/annotated-wait-group.go
@@ -4,6 +4,7 @@ import (
 	"fmt"
 	"strings"
 	"sync"
+	"sync/atomic"
 
 	"github.com/samber/lo"
 )
@@ -74,7 +75,7 @@ type waitGroupAnImpl struct {
 }
 
 func (a *waitGroupAnImpl) Add(delta int, name ...GoRoutineName) {
-	a.counter += int32(delta)
+	atomic.AddInt32(&a.counter, int32(delta))
 
 	if len(name) > 0 {
 		a.names[name[0]] = "foo"
@@ -84,7 +85,7 @@ func (a *waitGroupAnImpl) Add(delta int, name ...GoRoutineName) {
 }
 
 func (a *waitGroupAnImpl) Done(name ...GoRoutineName) {
-	a.counter--
+	atomic.AddInt32(&a.counter, int32(-1))
 
 	if len(name) > 0 {
 		delete(a.names, name[0])

Original file line number	Diff line number	Diff line change
`@@ -64,3 +64,4 @@ linters:`
`64`	`64`
`65`	`65`	`run:`
`66`	`66`	`issues-exit-code: 1`
	`67`	`+ timeout: 5m`
Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ import (`
`4`	`4`	`"fmt"`
`5`	`5`	`"strings"`
`6`	`6`	`"sync"`
	`7`	`+ "sync/atomic"`
`7`	`8`
`8`	`9`	`"github.com/samber/lo"`
`9`	`10`	`)`
`@@ -74,7 +75,7 @@ type waitGroupAnImpl struct {`
`74`	`75`	`}`
`75`	`76`
`76`	`77`	`func (a *waitGroupAnImpl) Add(delta int, name ...GoRoutineName) {`
`77`		`- a.counter += int32(delta)`
	`78`	`+ atomic.AddInt32(&a.counter, int32(delta))`
`78`	`79`
`79`	`80`	`if len(name) > 0 {`
`80`	`81`	`a.names[name[0]] = "foo"`
`@@ -84,7 +85,7 @@ func (a *waitGroupAnImpl) Add(delta int, name ...GoRoutineName) {`
`84`	`85`	`}`
`85`	`86`
`86`	`87`	`func (a *waitGroupAnImpl) Done(name ...GoRoutineName) {`
`87`		`- a.counter--`
	`88`	`+ atomic.AddInt32(&a.counter, int32(-1))`
`88`	`89`
`89`	`90`	`if len(name) > 0 {`
`90`	`91`	`delete(a.names, name[0])`