Skip to content

Commit 3bac6c4

Browse files
committed
ref(nav): rename skim to no-recurse (#423)
1 parent 3737e95 commit 3bac6c4

File tree

3 files changed

+17
-17
lines changed

3 files changed

+17
-17
lines changed

xfs/nav/helpers_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,8 +118,8 @@ type resumeTE struct {
118118

119119
type cascadeTE struct {
120120
naviTE
121-
skim bool
122-
depth uint
121+
noRecurse bool
122+
depth uint
123123
}
124124

125125
type resumeTestProfile struct {

xfs/nav/traverse-navigator-cascade_test.go

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ var _ = Describe("TraverseNavigatorCascade", Ordered, func() {
3232
o.Notify.OnBegin = begin("🛡️")
3333
o.Store.Subscription = entry.subscription
3434
o.Callback = entry.callback
35-
o.Store.Behaviours.Cascade.Skim = entry.skim
35+
o.Store.Behaviours.Cascade.NoRecurse = entry.noRecurse
3636
o.Store.Behaviours.Cascade.Depth = entry.depth
3737
}
3838

@@ -57,7 +57,7 @@ var _ = Describe("TraverseNavigatorCascade", Ordered, func() {
5757

5858
Entry(nil, &cascadeTE{
5959
naviTE: naviTE{
60-
message: "universal: Path contains folders only, skim",
60+
message: "universal: Path contains folders only, no-recurse",
6161
should: "traverse single level",
6262
relative: "RETRO-WAVE",
6363
subscription: nav.SubscribeAny,
@@ -67,12 +67,12 @@ var _ = Describe("TraverseNavigatorCascade", Ordered, func() {
6767
folders: 4,
6868
},
6969
},
70-
skim: true,
70+
noRecurse: true,
7171
}),
7272

7373
Entry(nil, &cascadeTE{
7474
naviTE: naviTE{
75-
message: "universal: Path contains files only, skim",
75+
message: "universal: Path contains files only, no-recurse",
7676
should: "traverse single level (containing files)",
7777
relative: "RETRO-WAVE/Chromatics/Night Drive",
7878
subscription: nav.SubscribeAny,
@@ -82,7 +82,7 @@ var _ = Describe("TraverseNavigatorCascade", Ordered, func() {
8282
folders: 1,
8383
},
8484
},
85-
skim: true,
85+
noRecurse: true,
8686
}),
8787

8888
Entry(nil, &cascadeTE{
@@ -134,7 +134,7 @@ var _ = Describe("TraverseNavigatorCascade", Ordered, func() {
134134

135135
Entry(nil, &cascadeTE{
136136
naviTE: naviTE{
137-
message: "universal: Path contains folders only, skim",
137+
message: "universal: Path contains folders only, no-recurse",
138138
should: "traverse single level",
139139
relative: "RETRO-WAVE",
140140
subscription: nav.SubscribeFolders,
@@ -144,12 +144,12 @@ var _ = Describe("TraverseNavigatorCascade", Ordered, func() {
144144
folders: 4,
145145
},
146146
},
147-
skim: true,
147+
noRecurse: true,
148148
}),
149149

150150
Entry(nil, &cascadeTE{
151151
naviTE: naviTE{
152-
message: "universal: Path contains files only, skim",
152+
message: "universal: Path contains files only, no-recurse",
153153
should: "traverse single level (containing files)",
154154
relative: "RETRO-WAVE/Chromatics/Night Drive",
155155
subscription: nav.SubscribeFolders,
@@ -159,7 +159,7 @@ var _ = Describe("TraverseNavigatorCascade", Ordered, func() {
159159
folders: 1,
160160
},
161161
},
162-
skim: true,
162+
noRecurse: true,
163163
}),
164164

165165
Entry(nil, &cascadeTE{
@@ -211,7 +211,7 @@ var _ = Describe("TraverseNavigatorCascade", Ordered, func() {
211211

212212
Entry(nil, &cascadeTE{
213213
naviTE: naviTE{
214-
message: "file: Path contains folders only, skim",
214+
message: "file: Path contains folders only, no-recurse",
215215
should: "traverse single level",
216216
relative: "RETRO-WAVE/Chromatics/Night Drive",
217217
subscription: nav.SubscribeFiles,
@@ -221,7 +221,7 @@ var _ = Describe("TraverseNavigatorCascade", Ordered, func() {
221221
folders: 0,
222222
},
223223
},
224-
skim: true,
224+
noRecurse: true,
225225
}),
226226

227227
Entry(nil, &cascadeTE{

xfs/nav/traverse-options.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ type CascadeBehaviour struct {
3232
//
3333
Depth uint
3434

35-
// Skim is an alternative to using Depth, but limits the traversal
35+
// NoRecurse is an alternative to using Depth, but limits the traversal
3636
// to just the path specified by the user. Since the raison d'etre
3737
// of the navigator is to recursively process a directory tree, using
38-
// Skim would appear to be contrary to its natural behaviour. However
38+
// NoRecurse would appear to be contrary to its natural behaviour. However
3939
// there are clear usage scenarios where a client needs to process
4040
// only the files in a specified directory.
4141
//
42-
Skim bool
42+
NoRecurse bool
4343
}
4444

4545
// NavigationBehaviours
@@ -306,7 +306,7 @@ func (o *TraverseOptions) afterUserOptions() {
306306
noEach := o.Sampler.Custom.Each == nil && o.Sampler.Custom.While != nil
307307
noWhile := o.Sampler.Custom.Each != nil && o.Sampler.Custom.While == nil
308308

309-
if o.Store.Behaviours.Cascade.Skim {
309+
if o.Store.Behaviours.Cascade.NoRecurse {
310310
o.Store.Behaviours.Cascade.Depth = 1
311311
}
312312

0 commit comments

Comments
 (0)