Skip to content

Commit 62ad27d

Browse files
authored
Merge pull request #551 from smartinez87/version-4.6.0
Version 4.6.0
2 parents 2f42744 + 02b27bf commit 62ad27d

File tree

14 files changed

+627
-156
lines changed

14 files changed

+627
-156
lines changed

.github/no-response.yml

Lines changed: 0 additions & 13 deletions
This file was deleted.

.github/workflows/main.yml

Lines changed: 21 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -9,22 +9,24 @@ jobs:
99
fail-fast: true
1010
matrix:
1111
ruby-version:
12-
- 2.6
13-
- 2.7
14-
- 3.0.0
15-
- 3.1
12+
# - 2.6
13+
# - 2.7
14+
# - 3.0.0
15+
# - 3.1
16+
- 3.3
1617
gemfile:
17-
- rails5_2.gemfile
18-
- rails6_0.gemfile
19-
- rails6_1.gemfile
20-
- rails7_0.gemfile
21-
exclude:
22-
- ruby-version: 2.6
23-
gemfile: rails7_0.gemfile
24-
- ruby-version: 3.0.0
25-
gemfile: rails5_2.gemfile
26-
- ruby-version: 3.1
27-
gemfile: rails5_2.gemfile
18+
# - gemfiles/rails5_2.gemfile
19+
# - gemfiles/rails6_0.gemfile
20+
# - gemfiles/rails6_1.gemfile
21+
# - gemfiles/rails7_0.gemfile
22+
- Gemfile
23+
# exclude:
24+
# - ruby-version: 2.6
25+
# gemfile: gemfiles/rails7_0.gemfile
26+
# - ruby-version: 3.0.0
27+
# gemfile: gemfiles/rails5_2.gemfile
28+
# - ruby-version: 3.1
29+
# gemfile: gemfiles/rails5_2.gemfile
2830
steps:
2931
- name: Checkout repository
3032
uses: actions/checkout@v2
@@ -36,10 +38,10 @@ jobs:
3638
bundler-cache: true
3739

3840
- name: Install required gems
39-
run: BUNDLE_GEMFILE=gemfiles/${{ matrix.gemfile }} bundle install --jobs=3 --retry=3
41+
run: BUNDLE_GEMFILE=${{ matrix.gemfile }} bundle install --jobs=3 --retry=3
4042

41-
- name: Run rspec tests
42-
run: BUNDLE_GEMFILE=gemfiles/${{ matrix.gemfile }} bundle exec rake test
43+
- name: Run tests
44+
run: BUNDLE_GEMFILE=${{ matrix.gemfile }} bundle exec rake test
4345

4446
rubocop:
4547
runs-on: ubuntu-latest
@@ -50,7 +52,7 @@ jobs:
5052
- name: Install Ruby
5153
uses: ruby/setup-ruby@v1
5254
with:
53-
ruby-version: 3.0.0
55+
ruby-version: 3.3.7
5456
bundler-cache: true
5557

5658
- name: Install required gems

.gitignore

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
/coverage/
22
*.gemfile.lock
3-
/Gemfile.lock
43
/.idea/

.rubocop_todo.yml

Lines changed: 97 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,66 +1,143 @@
11
# This configuration was generated by
22
# `rubocop --auto-gen-config`
3-
# on 2019-12-30 23:10:34 +0100 using RuboCop version 0.78.0.
3+
# on 2025-03-20 17:49:51 UTC using RuboCop version 1.74.0.
44
# The point is for the user to remove these configuration records
55
# one by one as the offenses are removed from the code base.
66
# Note that changes in the inspected code, or installation of new
77
# versions of RuboCop, may require this file to be generated again.
88

9+
# Offense count: 1
10+
# This cop supports safe autocorrection (--autocorrect).
11+
# Configuration parameters: EnforcedStyleAlignWith, Severity.
12+
# SupportedStylesAlignWith: start_of_line, begin
13+
Layout/BeginEndAlignment:
14+
Exclude:
15+
- 'test/exception_notifier/webhook_notifier_test.rb'
16+
17+
# Offense count: 1
18+
# This cop supports safe autocorrection (--autocorrect).
19+
Layout/EmptyLinesAroundMethodBody:
20+
Exclude:
21+
- 'test/exception_notifier/slack_notifier_test.rb'
22+
23+
# Offense count: 1
24+
# This cop supports safe autocorrection (--autocorrect).
25+
Layout/RescueEnsureAlignment:
26+
Exclude:
27+
- 'test/exception_notifier/webhook_notifier_test.rb'
28+
929
# Offense count: 4
30+
# Configuration parameters: AllowedMethods.
31+
# AllowedMethods: enums
32+
Lint/ConstantDefinitionInBlock:
33+
Exclude:
34+
- 'test/exception_notifier/modules/error_grouping_test.rb'
35+
- 'test/exception_notifier_test.rb'
36+
37+
# Offense count: 5
1038
Lint/RescueException:
1139
Exclude:
1240
- 'lib/exception_notification/rack.rb'
1341
- 'lib/exception_notification/sidekiq.rb'
1442
- 'lib/exception_notifier.rb'
1543

16-
# Offense count: 18
44+
# Offense count: 19
45+
# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
1746
Metrics/AbcSize:
18-
Max: 99
47+
Max: 102
1948

2049
# Offense count: 4
21-
# Configuration parameters: CountComments, ExcludedMethods.
22-
# ExcludedMethods: refine
50+
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
51+
# AllowedMethods: refine
2352
Metrics/BlockLength:
24-
Max: 87
53+
Max: 68
2554

26-
# Offense count: 11
27-
# Configuration parameters: CountComments.
55+
# Offense count: 2
56+
# Configuration parameters: CountComments, CountAsOne.
2857
Metrics/ClassLength:
29-
Max: 177
58+
Max: 155
3059

3160
# Offense count: 7
61+
# Configuration parameters: AllowedMethods, AllowedPatterns.
3262
Metrics/CyclomaticComplexity:
3363
Max: 25
3464

35-
# Offense count: 26
36-
# Configuration parameters: CountComments, ExcludedMethods.
65+
# Offense count: 24
66+
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
3767
Metrics/MethodLength:
38-
Max: 89
68+
Max: 31
3969

4070
# Offense count: 1
41-
# Configuration parameters: CountComments.
42-
Metrics/ModuleLength:
43-
Max: 107
71+
# Configuration parameters: Max, CountKeywordArgs.
72+
Metrics/ParameterLists:
73+
MaxOptionalParameters: 5
4474

4575
# Offense count: 6
76+
# Configuration parameters: AllowedMethods, AllowedPatterns.
4677
Metrics/PerceivedComplexity:
4778
Max: 25
4879

49-
# Offense count: 6
80+
# Offense count: 3
81+
# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
82+
# SupportedStyles: snake_case, normalcase, non_integer
83+
# AllowedIdentifiers: TLS1_1, TLS1_2, capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
84+
Naming/VariableNumber:
85+
Exclude:
86+
- 'test/exception_notification/rake_test.rb'
87+
88+
# Offense count: 3
89+
# This cop supports safe autocorrection (--autocorrect).
90+
# Configuration parameters: EnforcedStyle.
91+
# SupportedStyles: separated, grouped
92+
Style/AccessorGrouping:
93+
Exclude:
94+
- 'lib/exception_notifier/hipchat_notifier.rb'
95+
96+
# Offense count: 8
5097
Style/ClassVars:
5198
Exclude:
5299
- 'lib/exception_notifier.rb'
53100
- 'test/exception_notifier/modules/error_grouping_test.rb'
54101
- 'test/support/exception_notifier_helper.rb'
55102

103+
# Offense count: 1
104+
# This cop supports safe autocorrection (--autocorrect).
105+
# Configuration parameters: Keywords, RequireColon.
106+
# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE
107+
Style/CommentAnnotation:
108+
Exclude:
109+
- 'lib/exception_notification/sidekiq.rb'
110+
111+
# Offense count: 1
112+
# This cop supports safe autocorrection (--autocorrect).
113+
Style/ExpandPathArguments:
114+
Exclude:
115+
- 'examples/sinatra/config.ru'
116+
117+
# Offense count: 1
118+
# This cop supports unsafe autocorrection (--autocorrect-all).
119+
Style/GlobalStdStream:
120+
Exclude:
121+
- 'lib/exception_notifier.rb'
122+
56123
# Offense count: 2
57-
Style/MethodMissingSuper:
124+
Style/MissingRespondToMissing:
58125
Exclude:
59126
- 'lib/exception_notifier/email_notifier.rb'
60127
- 'lib/exception_notifier/teams_notifier.rb'
61128

62-
# Offense count: 2
63-
Style/MissingRespondToMissing:
129+
# Offense count: 1
130+
# This cop supports safe autocorrection (--autocorrect).
131+
Style/RedundantParentheses:
64132
Exclude:
65133
- 'lib/exception_notifier/email_notifier.rb'
66-
- 'lib/exception_notifier/teams_notifier.rb'
134+
135+
# Offense count: 4
136+
# This cop supports unsafe autocorrection (--autocorrect-all).
137+
# Configuration parameters: Mode.
138+
Style/StringConcatenation:
139+
Exclude:
140+
- 'lib/exception_notifier/email_notifier.rb'
141+
- 'lib/exception_notifier/irc_notifier.rb'
142+
- 'lib/exception_notifier/sns_notifier.rb'
143+
- 'lib/exception_notifier/teams_notifier.rb'

.ruby-version

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
3.3.7

0 commit comments

Comments
 (0)