fix(chain): ListChainSelectors filter with multiple families (#119)

- Use map instead of slice for faster lookup
- WithFamily now supports more than 1 family, eg
`ListChainSelectors(WithFamily("evm"), WithFamily("aptos")`

Author: graham-chainlink

.changeset/gold-eels-exist.md

@@ -0,0 +1,5 @@
+---
+"chainlink-deployments-framework": patch
+---
+
+ListChainSelectors can filter multiple families

chain/blockchain.go

@@ -144,22 +144,32 @@ func (b BlockChains) TonChains() map[uint64]ton.Chain {
 type ChainSelectorsOption func(*chainSelectorsOptions)
 
 type chainSelectorsOptions struct {
-	family    string
-	excluding []uint64
+	// Use map for faster lookups
+	includedFamilies  map[string]struct{}
+	excludedChainSels map[uint64]struct{}
 }
 
 // WithFamily returns an option to filter chains by family (evm, solana, aptos)
 // Use constants from chain_selectors package eg WithFamily(chain_selectors.FamilySolana)
+// This can be used more than once to include multiple families.
 func WithFamily(family string) ChainSelectorsOption {
 	return func(o *chainSelectorsOptions) {
-		o.family = family
+		if o.includedFamilies == nil {
+			o.includedFamilies = make(map[string]struct{})
+		}
+		o.includedFamilies[family] = struct{}{}
 	}
 }
 
 // WithChainSelectorsExclusion returns an option to exclude specific chain selectors
 func WithChainSelectorsExclusion(chainSelectors []uint64) ChainSelectorsOption {
 	return func(o *chainSelectorsOptions) {
-		o.excluding = chainSelectors
+		if o.excludedChainSels == nil {
+			o.excludedChainSels = make(map[uint64]struct{})
+		}
+		for _, selector := range chainSelectors {
+			o.excludedChainSels[selector] = struct{}{}
+		}
 	}
 }
 
@@ -168,11 +178,7 @@ func WithChainSelectorsExclusion(chainSelectors []uint64) ChainSelectorsOption {
 // - WithFamily: filter by family eg WithFamily(chain_selectors.FamilySolana)
 // - WithChainSelectorsExclusion: exclude specific chain selectors
 func (b BlockChains) ListChainSelectors(options ...ChainSelectorsOption) []uint64 {
-	// Initialize default options
-	opts := chainSelectorsOptions{
-		family:    "",
-		excluding: []uint64{},
-	}
+	opts := chainSelectorsOptions{}
 
 	// Apply all provided options
 	for _, option := range options {
@@ -182,14 +188,13 @@ func (b BlockChains) ListChainSelectors(options ...ChainSelectorsOption) []uint6
 	selectors := make([]uint64, 0, len(b.chains))
 
 	for selector, chain := range b.chains {
-		// Skip if in exclusion list
-		if slices.Contains(opts.excluding, selector) {
-			continue
+		if opts.excludedChainSels != nil {
+			if _, excluded := opts.excludedChainSels[selector]; excluded {
+				continue
+			}
 		}
-
-		// Apply family filter if specified
-		if opts.family != "" {
-			if opts.family != chain.Family() {
+		if opts.includedFamilies != nil {
+			if _, ok := opts.includedFamilies[chain.Family()]; !ok {
 				continue
 			}
 		}

chain/blockchain_test.go

@@ -230,6 +230,12 @@ func TestBlockChainsListChainSelectors(t *testing.T) {
 			expectedIDs: []uint64{tonChain1.Selector},
 			description: "expected Ton chain selectors",
 		},
+		{
+			name:        "with multiple families",
+			options:     []chain.ChainSelectorsOption{chain.WithFamily(chain_selectors.FamilyEVM), chain.WithFamily(chain_selectors.FamilySolana)},
+			expectedIDs: []uint64{evmChain1.Selector, evmChain2.Selector, solanaChain1.Selector},
+			description: "expected EVM and Solana chain selectors",
+		},
 		{
 			name: "with exclusion",
 			options: []chain.ChainSelectorsOption{chain.WithChainSelectorsExclusion(
@@ -260,7 +266,7 @@ func TestBlockChainsListChainSelectors(t *testing.T) {
 }
 
 // buildBlockChains creates a new BlockChains instance with the test chains.
-// 2 evm chains, 1 solana chain, 1 aptos chain, 1 sui chain
+// 2 evm chains, 1 solana chain, 1 aptos chain, 1 sui chain, 1 ton chain.
 func buildBlockChains() chain.BlockChains {
 	chains := chain.NewBlockChains(map[uint64]chain.BlockChain{
 		evmChain1.ChainSelector():    evmChain1,