fix(chain): rename AllChains to All and return iterator (#136)

Returning Iterator instead of map for All method

Author: graham-chainlink

.changeset/grumpy-apples-speak.md

@@ -0,0 +1,5 @@
+---
+"chainlink-deployments-framework": patch
+---
+
+rename AllChains to All

chain/blockchain.go

@@ -1,6 +1,8 @@
 package chain
 
 import (
+	"iter"
+	"maps"
 	"slices"
 
 	"github.com/smartcontractkit/chainlink-deployments-framework/chain/aptos"
@@ -83,15 +85,9 @@ func (b BlockChains) ExistsN(selectors ...uint64) bool {
 	return true
 }
 
-// AllChains returns a map of all chains with their selectors as key.
-func (b BlockChains) AllChains() map[uint64]BlockChain {
-	// Return a copy of the chains map to avoid external mutations
-	chainsCopy := make(map[uint64]BlockChain, len(b.chains))
-	for k, v := range b.chains {
-		chainsCopy[k] = v
-	}
-
-	return chainsCopy
+// All returns an iterator over all chains with their selectors.
+func (b BlockChains) All() iter.Seq2[uint64, BlockChain] {
+	return maps.All(b.chains)
 }
 
 // EVMChains returns a map of all EVM chains with their selectors.

chain/blockchain_test.go

@@ -1,6 +1,7 @@
 package chain_test
 
 import (
+	"maps"
 	"testing"
 
 	"github.com/stretchr/testify/assert"
@@ -56,7 +57,7 @@ func TestNewBlockChainsFromSlice(t *testing.T) {
 		chains := chain.NewBlockChainsFromSlice(nil)
 
 		require.NotNil(t, chains)
-		assert.Empty(t, chains.AllChains(), "expected empty chains map")
+		assert.Empty(t, maps.Collect(chains.All()), "expected empty chains map")
 	})
 
 	t.Run("populated slice", func(t *testing.T) {
@@ -65,7 +66,7 @@ func TestNewBlockChainsFromSlice(t *testing.T) {
 		chains := chain.NewBlockChainsFromSlice([]chain.BlockChain{evmChain1, solanaChain1})
 
 		require.NotNil(t, chains)
-		assert.Len(t, chains.AllChains(), 2, "expected 2 chains")
+		assert.Len(t, maps.Collect(chains.All()), 2, "expected 2 chains")
 	})
 }
 
@@ -138,17 +139,16 @@ func TestBlockChainsAllChains(t *testing.T) {
 
 	chains := buildBlockChains()
 
-	allChains := chains.AllChains()
+	allChains := maps.Collect(chains.All())
 
-	assert.Len(t, allChains, 6, "expected 6 chains")
-
-	// Check if all expected chains are present
 	expectedSelectors := []uint64{
 		evmChain1.Selector, evmChain2.Selector,
 		solanaChain1.Selector, aptosChain1.Selector,
 		suiChain1.Selector, tonChain1.Selector,
 	}
 
+	assert.Len(t, allChains, len(expectedSelectors))
+
 	for _, selector := range expectedSelectors {
 		_, exists := allChains[selector]
 		assert.True(t, exists, "expected chain with selector %d", selector)