You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
# This is the 1st commit message:
add lib files for sticky-header
add chose parent
add support to 'optional 'cdkStickyRegion' input '
add app-demo for sticky-header
fix bugs and deleted unused tag id in HTML files
modify
fix some code according to PR review comments
change some format to pass TSlint check
add '_' before private elements
delete @Injectable for StickyHeaderDirective. Because we do not need @Injectable
refine code
encapsulate 'set style for element'
change @input()
Delete 'Observable.fromEvent(this.upperScrollableContainer, 'scroll')'
add const STICK_START_CLASS and STICK_END_CLASS
Add doc for [cdkStickyRegion] and 'unstuckElement()'. Delete 'detach()' function, add its content into 'ngOnDestroy()'.
change 'MdStickyHeaderModule' to 'CdkStickyHeaderModule';
encapsulate reset css style operation for sticky header.
delete unnecessary gloable variables
delete global variable '_width'
Add doc for 'sticker()' function. explained how it works.
add more doc for 'sticker()', explaining 'isStuck' flag
2 space for indent
fix
delete sticky-header demo part from this branch
revert firebase file
change code according to comments in PR
revert firbaserc
revert demo-app.ts
revert routes.ts
revert demo-app-module.ts
change
fix the problem of : 'this.stickyParent' might be 'null'
change doc
Change the constructor of 'cdkStickyRegion' to 'constructor(public readonly _elementRef: ElementRef) { }'
Added prefix 'mat-' for CSS class
Delete 'public' before variables
Object.assign isn't supported in IE11; use extendObject from src/lib/core/util.
IE11 will have trouble with `translate3d(0, 0, 0);', change to `translate3d(0px, 0px, 0px);'
Added docs for all variables
extract 'generate CSS style'
created a generateStyleCSS() function, let it be responsible for generating all those CSS styles.
reformat
add debounce to solve 'getBoundingClientRect() cause slow down' problem.
add position:sticky and check whether browser support it. If not , use the naive implementation
removed unused import
Removed unused 'scrollableRegion' and 'parentRegion'
removed commented lines
default public
Add comments about why setting style top and position for iPhone and not IE. And extract detectBrowser() as a new function
format
consider all circumstances of browser.
use "===" instead of '=='
make 'navigator.userAgent.toLocaleLowerCase()' a local variable
optimize
Added comments on const 'STICK_START_CLASS' and 'STICK_END_CLASS'.
change their content to cdk-sticky-header-start and cdk-sticky-header-end
Added comments for STICK_START_CLASS and STICK_END_CLASS.
Changed the format of one-line JsDoc
unsubscribe sbscriptions onDestory
Use what modernizr does on compatibility instead of get the browser version directly.
add 'padding' and 'stickyRegionHeight' variables to avoid calling 'getComputedStyle()' too many times (which is expensive).
move docs above @directive
removed the underscore in'_element: ElementRef',
expand 'reg' to 'region'
use 'if (this.isIE)' instead of 'if(this.isIE === true)'
added more newlines between params in 'generateCssStyle()' function to make it easier to understand.
Added reference link to Modernizer in docs of getSupportList()
Deleted "_supportList" variable
renamed 'isIE' to 'isStickyPositionSupported', and removed extra space before Observable
Set debounce time as a const variable
Added docs for 'const DEBOUNCE_TIME: number = 5;'
Changed ' if(this.stickyParent == null)' to ' if(!this.stickyParent)'
Removed the @param and @returns and make sure the types are correct in the function signature in 'generateCssStyle(...)' function
Added docs for `isStickyPositionSupported` variable
changed '+=' to '=' of 'stickyText' in getSupportList() function
nit added " " between 'if' and '('
nit
Added comments
deleted unused import
change comments
optimize comments
deleted unnecessary global variables(padding and stickyRegionHeight)
Added check whether we are on browser
Array<string> to string[]
test?
try to reopen the old PR
fix after rebase
revert list.ts
test
test 222
revert demo
revert list.ts second time
Move code to 'src/cdk'
revert 'move code to 'src/cdk'' , it should be done in a new PR
revert
avoid calling 'getComputedStyle()' too many times.
rename as sticky-header.ts
# This is the commit message angular#2:
imported PlatformModule
# This is the commit message angular#3:
Add blank lines between these top-level symbol
# This is the commit message angular#4:
make '_isStickyPositionSupported' private
# This is the commit message angular#5:
Changed the originalCSS to private and use '{} as CSSStyleDeclaration' instead of ''any.
0 commit comments