Skip to content

Commit 90f78e8

Browse files
committed
Detail TODO comments; remove unneeded trusted root in e2e tests
Signed-off-by: Zach Steindler <[email protected]>
1 parent 5d294a4 commit 90f78e8

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

cmd/conformance/main.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ func usage() {
5050
func parseArgs() {
5151
for i := 2; i < len(os.Args); {
5252
switch os.Args[i] {
53-
// TODO: support staging
53+
// TODO: support staging (see https://github.com/sigstore/cosign/issues/2434)
5454
//
5555
// Today cosign signing does not yet use sigstore-go, and so we would
5656
// need to make some clever invocation of `cosign initialize` to
@@ -112,6 +112,7 @@ func main() {
112112
args = append(args, "verify-blob")
113113

114114
// TODO: for now, we handle `verify` by constructing a bundle
115+
// (see https://github.com/sigstore/cosign/issues/3700)
115116
//
116117
// Today cosign only supports `--trusted-root` with the new bundle
117118
// format. When cosign supports `--trusted-root` with detached signed

test/e2e_test.go

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1628,12 +1628,6 @@ func TestSignBlobNewBundle(t *testing.T) {
16281628
t.Fatal(err)
16291629
}
16301630

1631-
trustedRoot := "{\"mediaType\":\"application/vnd.dev.sigstore.trustedroot+json;version=0.1\"}"
1632-
trustedRootPath := filepath.Join(td1, "trusted_root.json")
1633-
if err := os.WriteFile(trustedRootPath, []byte(trustedRoot), 0644); err != nil {
1634-
t.Fatal(err)
1635-
}
1636-
16371631
bundlePath := filepath.Join(td1, "bundle.sigstore.json")
16381632

16391633
ctx := context.Background()

0 commit comments

Comments
 (0)