Skip to content

Conversation

@pjanotti
Copy link
Contributor

@pjanotti pjanotti commented Dec 4, 2025

Description: Removed the deprecated localhost config endpoint and related environment variables.

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.83%. Comparing base (c1e8125) to head (4dc8398).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
internal/configconverter/expvar.go 82.85% 6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (83.33%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6984      +/-   ##
==========================================
- Coverage   38.00%   37.83%   -0.17%     
==========================================
  Files         367      366       -1     
  Lines       25713    25619      -94     
==========================================
- Hits         9771     9692      -79     
+ Misses      15129    15116      -13     
+ Partials      813      811       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pjanotti
Copy link
Contributor Author

pjanotti commented Dec 4, 2025

@pjanotti pjanotti marked this pull request as ready for review December 4, 2025 17:26
@pjanotti pjanotti requested a review from a team as a code owner December 4, 2025 17:26
Copilot AI review requested due to automatic review settings December 4, 2025 17:26
@pjanotti pjanotti requested review from a team as code owners December 4, 2025 17:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the deprecated localhost debug config endpoint (http://localhost:55554/debug/configz) and all related environment variables (SPLUNK_DEBUG_CONFIG_SERVER and SPLUNK_DEBUG_CONFIG_SERVER_PORT). The functionality has been replaced by the expvarz endpoint available through the zpages extension.

Key changes:

  • Deleted the ConfigServer implementation and its tests
  • Removed environment variable references from scripts and configuration files
  • Moved redaction utility functions to the ExpvarConverter
  • Updated test files to remove config server dependencies

Reviewed changes

Copilot reviewed 18 out of 21 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
internal/configconverter/config_server.go Deleted deprecated ConfigServer implementation
internal/configconverter/config_server_test.go Deleted ConfigServer tests
internal/configconverter/expvar.go Added simpleRedact and shouldRedactKey utility functions
cmd/otelcol/main.go Removed ConfigServer initialization and registration
cmd/otelcol/main_test.go Updated port waits from 55554 to 55679 (zpages)
packaging/msi/splunk-support-bundle.ps1 Removed localhost:55554 config collection
packaging/fpm/etc/otel/collector/splunk-support-bundle.sh Removed localhost:55554 config collection
packaging/technical-addon/Splunk_TA_otel/windows_x86_64/bin/Splunk_TA_otel.cmd Removed SPLUNK_DEBUG_CONFIG_SERVER environment variable handling
packaging/technical-addon/Splunk_TA_otel/linux_x86_64/bin/Splunk_TA_otel.sh Removed SPLUNK_DEBUG_CONFIG_SERVER environment variable handling
packaging/technical-addon/Splunk_TA_otel/README/inputs.conf.spec Removed splunk_debug_config_server parameter documentation
packaging/technical-addon/packaging-scripts/cicd-tests/envvars/envvartest.sh Removed SPLUNK_DEBUG_CONFIG_SERVER test references
packaging/technical-addon/packaging-scripts/cicd-tests/envvars/passthrough_env_vars.yaml Removed SPLUNK_DEBUG_CONFIG_SERVER passthrough configuration
tests/general/discoverymode/configd_test.go Removed SPLUNK_DEBUG_CONFIG_SERVER=false from test command
tests/general/discoverymode/docker_observer_discovery_test.go Removed SPLUNK_DEBUG_CONFIG_SERVER=false from test command
tests/general/discoverymode/host_observer_discovery_test.go Removed SPLUNK_DEBUG_CONFIG_SERVER=false from test command
tests/general/configsources/vault_test.go Updated comment to remove reference to config endpoint
.github/workflows/win-package-test.yml Added working-directory specification for test commands
.github/workflows/scripts/win-required-ports.ps1 Removed port 55554 reservation
go.mod Removed unused test dependencies
go.sum Removed checksums for unused dependencies
.chloggen/remove-config-debug-server.yaml Added changelog entry for breaking change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these working-directory changes related to this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes they are. Removal of the component triggered changes to go.mod, and those required the working-directory. To be fair I don't fully understand why that is the case, but after the changes to with go.mod and respective tidy this is the simplest fix that I found.

Copilot AI review requested due to automatic review settings December 4, 2025 23:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 21 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 5, 2025 01:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 21 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings December 5, 2025 16:27
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 18 out of 21 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants