-
Notifications
You must be signed in to change notification settings - Fork 173
Remove deprecated localhost debug config endpoint #6984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (83.33%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6984 +/- ##
==========================================
- Coverage 38.00% 37.83% -0.17%
==========================================
Files 367 366 -1
Lines 25713 25619 -94
==========================================
- Hits 9771 9692 -79
+ Misses 15129 15116 -13
+ Partials 813 811 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the deprecated localhost debug config endpoint (http://localhost:55554/debug/configz) and all related environment variables (SPLUNK_DEBUG_CONFIG_SERVER and SPLUNK_DEBUG_CONFIG_SERVER_PORT). The functionality has been replaced by the expvarz endpoint available through the zpages extension.
Key changes:
- Deleted the
ConfigServerimplementation and its tests - Removed environment variable references from scripts and configuration files
- Moved redaction utility functions to the
ExpvarConverter - Updated test files to remove config server dependencies
Reviewed changes
Copilot reviewed 18 out of 21 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/configconverter/config_server.go | Deleted deprecated ConfigServer implementation |
| internal/configconverter/config_server_test.go | Deleted ConfigServer tests |
| internal/configconverter/expvar.go | Added simpleRedact and shouldRedactKey utility functions |
| cmd/otelcol/main.go | Removed ConfigServer initialization and registration |
| cmd/otelcol/main_test.go | Updated port waits from 55554 to 55679 (zpages) |
| packaging/msi/splunk-support-bundle.ps1 | Removed localhost:55554 config collection |
| packaging/fpm/etc/otel/collector/splunk-support-bundle.sh | Removed localhost:55554 config collection |
| packaging/technical-addon/Splunk_TA_otel/windows_x86_64/bin/Splunk_TA_otel.cmd | Removed SPLUNK_DEBUG_CONFIG_SERVER environment variable handling |
| packaging/technical-addon/Splunk_TA_otel/linux_x86_64/bin/Splunk_TA_otel.sh | Removed SPLUNK_DEBUG_CONFIG_SERVER environment variable handling |
| packaging/technical-addon/Splunk_TA_otel/README/inputs.conf.spec | Removed splunk_debug_config_server parameter documentation |
| packaging/technical-addon/packaging-scripts/cicd-tests/envvars/envvartest.sh | Removed SPLUNK_DEBUG_CONFIG_SERVER test references |
| packaging/technical-addon/packaging-scripts/cicd-tests/envvars/passthrough_env_vars.yaml | Removed SPLUNK_DEBUG_CONFIG_SERVER passthrough configuration |
| tests/general/discoverymode/configd_test.go | Removed SPLUNK_DEBUG_CONFIG_SERVER=false from test command |
| tests/general/discoverymode/docker_observer_discovery_test.go | Removed SPLUNK_DEBUG_CONFIG_SERVER=false from test command |
| tests/general/discoverymode/host_observer_discovery_test.go | Removed SPLUNK_DEBUG_CONFIG_SERVER=false from test command |
| tests/general/configsources/vault_test.go | Updated comment to remove reference to config endpoint |
| .github/workflows/win-package-test.yml | Added working-directory specification for test commands |
| .github/workflows/scripts/win-required-ports.ps1 | Removed port 55554 reservation |
| go.mod | Removed unused test dependencies |
| go.sum | Removed checksums for unused dependencies |
| .chloggen/remove-config-debug-server.yaml | Added changelog entry for breaking change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these working-directory changes related to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes they are. Removal of the component triggered changes to go.mod, and those required the working-directory. To be fair I don't fully understand why that is the case, but after the changes to with go.mod and respective tidy this is the simplest fix that I found.
Co-authored-by: Curtis Robert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 18 out of 21 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 18 out of 21 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 18 out of 21 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description: Removed the deprecated localhost config endpoint and related environment variables.