[smartagent/docker-container-stats] Use client API negotiation instead of fixed version

[pjanotti]

With the release of Docker Engine v29 the fixed version of the monitor is not accepted by default, producing the error message:

level=error msg="Error watching docker container events" error="Error response from daemon: client version 1.24 is too old. Minimum supported API version is 1.44, please upgrade your client to a newer version" monitorID= monitorType=docker-container-stats

This change adds a dedicated test to verify this scenario ensuring that with the fix it works OOTB for the default configuration of the Docker Engine v29 and keeps working also for the ones that adopted the temporary workaround described here.

Example of the new test failure when the fix is not in place: https://github.com/signalfx/splunk-otel-collector/actions/runs/19444329447/job/55635128801?pr=6941#step:4:168

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 37.94%. Comparing base (2c59550) to head (caec134).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
...ernal/signalfx-agent/pkg/monitors/docker/docker.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6941   +/-   ##
=======================================
  Coverage   37.93%   37.94%           
=======================================
  Files         367      367           
  Lines       25743    25743           
=======================================
+ Hits         9765     9767    +2     
+ Misses      15165    15163    -2     
  Partials      813      813           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull Request Overview

This PR fixes a compatibility issue where the smartagent/docker-container-stats monitor fails with Docker Engine v29 due to using a fixed API version (v1.24) that is below the minimum supported version (v1.44). The fix replaces the fixed version with client API version negotiation to support a wider range of Docker engine versions.

• Replaces docker.WithVersion("v1.24") with docker.WithAPIVersionNegotiation() in the Docker client initialization
• Adds comprehensive integration test to verify compatibility with both default and custom Docker daemon configurations
• Includes shell script for upgrading Docker daemon to latest version in test environments

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
internal/signalfx-agent/pkg/monitors/docker/docker.go	Replaces fixed API version with API version negotiation
internal/signalfx-agent/pkg/monitors/docker/docker_test.go	Adds integration test for minimum client version compatibility
internal/signalfx-agent/pkg/monitors/docker/testdata/upgrade-dockerd-on-ubuntu.sh	Provides script to upgrade Docker daemon on Ubuntu test runners
.github/workflows/build-and-test.yml	Adds isolated job for Docker daemon upgrade testing
.chloggen/fix-docker-monitor-min-client-ver.yaml	Documents the bug fix in changelog

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.