Skip to content

Conversation

@pjanotti
Copy link
Contributor

Per conversation removing this component since it was discontinued on OTel Collector Contrib.

Copilot AI review requested due to automatic review settings November 13, 2025 19:24
@pjanotti pjanotti requested review from a team as code owners November 13, 2025 19:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the discontinued ecs_task_observer extension from the Splunk OpenTelemetry Collector distribution, following its removal from the upstream OpenTelemetry Collector Contrib repository in PR #43818.

  • Removed all references to ecstaskobserver from code, tests, and documentation
  • Cleaned up dependencies in go.mod and go.sum
  • Added breaking change changelog entry documenting the removal

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/confmapprovider/discovery/discoverer.go Removed ecstaskobserver import and factory registration from observer factory map
internal/components/components_test.go Removed ecs_task_observer from expected extensions list in tests
internal/components/components.go Removed ecstaskobserver import and factory initialization
go.mod Removed ecstaskobserver dependency from required packages
go.sum Removed ecstaskobserver checksums
docs/components.md Removed ecs_task_observer from extensions documentation table
.chloggen/remove-ecstaskobserver.yaml Added breaking change changelog entry with removal details

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.91%. Comparing base (f283ce6) to head (1f2f9d3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6936      +/-   ##
==========================================
- Coverage   37.96%   37.91%   -0.05%     
==========================================
  Files         367      367              
  Lines       25745    25743       -2     
==========================================
- Hits         9773     9760      -13     
- Misses      15161    15168       +7     
- Partials      811      815       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pjanotti pjanotti merged commit 80f5a28 into main Nov 14, 2025
239 checks passed
@pjanotti pjanotti deleted the remove-ecstaskobserver branch November 14, 2025 00:09
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants