-
Notifications
You must be signed in to change notification settings - Fork 173
OTL-3623 Deprecate script receiver #6893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
7296146
OTL-3623 Deprecate script receiver
akhileshsingh85 d58db55
fix changelog validation failure
akhileshsingh85 02a0f4f
Update deprected message
akhileshsingh85 65d171b
Resolve lychee github action failure
akhileshsingh85 2ab40c0
Remove failed test cases for scriptedinputs receiver
akhileshsingh85 b579d63
Merge branch 'main' into deprecate-script-receiver
akhileshsingh85 36db9f1
Merge branch 'main' into deprecate-script-receiver
akhileshsingh85 9af7006
Merge branch 'main' into deprecate-script-receiver
akhileshsingh85 dd228d6
Merge branch 'main' into deprecate-script-receiver
akhileshsingh85 b6717d3
Update docs to processors
akhileshsingh85 6e03ba9
Merge branch 'main' into deprecate-script-receiver
akhileshsingh85 1409ee1
Merge branch 'main' into deprecate-script-receiver
akhileshsingh85 b1087ad
Merge branch 'main' into deprecate-script-receiver
akhileshsingh85 2f1a3d3
Revert the replacement comment.
akhileshsingh85 f60e56c
Added link for the scripted input receiver
akhileshsingh85 a53e2b8
Merge branch 'main' into deprecate-script-receiver
akhileshsingh85 ee5358e
Remove the replacement comment from the README.md file
akhileshsingh85 3a82b52
Merge branch 'main' into deprecate-script-receiver
akhileshsingh85 7a0e548
Merge branch 'main' into deprecate-script-receiver
akhileshsingh85 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: deprecation | ||
|
|
||
| # The name of the component, or a single word describing the area of concern, (e.g. crosslink) | ||
| component: scriptedinputsreceiver | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Deprecate the scripted inputs receiver. Please use native OTel Collector receivers instead, such as the hostmetricsreceiver for system metrics. | ||
|
|
||
| # One or more tracking issues related to the change | ||
| issues: [6893] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| # Scripted Inputs Receiver Deprecation | ||
|
|
||
| The Scripted Inputs Receiver has been deprecated and will be removed in a future release. | ||
|
|
||
| ## Replacement guidance | ||
|
|
||
| The Scripted Inputs Receiver was designed to replicate log collection behavior of the Splunk Universal Forwarder when the [Unix and Linux Technical Add-on](https://docs.splunk.com/Documentation/AddOns/released/UnixLinux/About) is installed. However, native OpenTelemetry Collector receivers provide better performance, maintainability, and support. | ||
|
|
||
| ### Recommended Replacements | ||
|
|
||
| For system metrics collection, we recommend using the [Host Metrics Receiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/hostmetricsreceiver), which provides comprehensive system monitoring capabilities. | ||
|
|
||
| #### Migration Mapping | ||
|
|
||
| Below is a mapping of scripted input scripts to their recommended OTel Collector receiver alternatives: | ||
|
|
||
| | Scripted Input | Recommended Receiver | Notes | | ||
| |----------------|---------------------|--------| | ||
| | `cpu`, `iostat`, `vmstat` | [hostmetricsreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/hostmetricsreceiver) | Use CPU, disk, memory, and process scrapers | | ||
| | `df` | [hostmetricsreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/hostmetricsreceiver) | Use filesystem scraper | | ||
| | `netstat`, `bandwidth`, `interfaces`, `protocol` | [hostmetricsreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/hostmetricsreceiver) | Use network scraper | | ||
| | `nfsiostat` | [hostmetricsreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/hostmetricsreceiver) | Use NFS scraper | | ||
| | `ps`, `top`, `lsof` | [hostmetricsreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/hostmetricsreceiver) | Use process scraper | | ||
| | `package`, `service`, `version`, `hardware` | [filelogreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/filelogreceiver) | For log-based data collection | | ||
| | `lastlog`, `who`, `passwd`, `usersWithLoginPrivs` | [filelogreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/filelogreceiver) | Monitor system log files | | ||
| | `rlog` | [filelogreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/filelogreceiver) | Monitor `/var/log/audit/audit.log` | | ||
| | `openPorts`, `openPortsEnhanced` | [hostmetricsreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/hostmetricsreceiver) | Use network scraper or custom monitoring solution | | ||
| | `selinuxChecker`, `sshdChecker`, `vsftpdChecker` | [filelogreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/filelogreceiver) | Monitor configuration files | | ||
| | `time`, `uptime` | [hostmetricsreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/hostmetricsreceiver) or [ntpreceiver](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/ntpreceiver) | For uptime and time sync monitoring | | ||
| | `update` | Custom monitoring solution | No direct receiver replacement available for package updates | | ||
|
|
||
| ### Example: Migrating from df script to Host Metrics Receiver | ||
|
|
||
| **Before (Scripted Inputs):** | ||
| ```yaml | ||
| receivers: | ||
| scripted_inputs/df: | ||
| script_name: df | ||
| collection_interval: 10s | ||
| source: df | ||
| sourcetype: df | ||
|
|
||
| service: | ||
| pipelines: | ||
| logs: | ||
| receivers: [scripted_inputs/df] | ||
| processors: [memory_limiter, batch] | ||
| exporters: [splunk_hec] | ||
| ``` | ||
| **After (Host Metrics Receiver):** | ||
| ```yaml | ||
| receivers: | ||
| hostmetrics: | ||
| collection_interval: 10s | ||
| scrapers: | ||
| filesystem: | ||
| metrics: | ||
| system.filesystem.usage: | ||
| enabled: true | ||
| system.filesystem.utilization: | ||
| enabled: true | ||
|
|
||
| processors: | ||
| resource: | ||
| attributes: | ||
| - key: com.splunk.source | ||
| value: hostmetrics | ||
| action: upsert | ||
| - key: com.splunk.sourcetype | ||
| value: otel | ||
| action: upsert | ||
|
|
||
| service: | ||
| pipelines: | ||
| metrics: | ||
| receivers: [hostmetrics] | ||
| processors: [resource, memory_limiter, batch] | ||
akhileshsingh85 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| exporters: [splunk_hec] | ||
| ``` | ||
| ### Additional Resources | ||
| - [Host Metrics Receiver Documentation](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/hostmetricsreceiver) | ||
| - [File Log Receiver Documentation](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/filelogreceiver) | ||
| - [Splunk OpenTelemetry Collector Configuration Examples](https://github.com/signalfx/splunk-otel-collector/tree/main/examples) | ||
| ## Timeline | ||
| - **Deprecation Notice**: Current release | ||
| - **Planned Removal**: Future release (to be announced) | ||
| Please plan to migrate to the recommended alternatives at your earliest convenience. | ||
akhileshsingh85 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused by this guide, but I also don't have any experience with this receiver, so my questions and confusion may be totally off here. The receiver only supports logs, but the replacement guidance is to use a metrics receiver instead, will that provide the equivalent functionality here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crobert-1 Can you suggest the alternative replacement guidance .
@dmitryax Can you confirm that the replacement guidance to use metric receiver is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @crobert-1 , the hostmetrics receiver is not a replacement because it sends metrics.
@akhileshsingh85 The decision to deprecate this is made after we've confirmed that no customer is using it.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just deprecate it with messaging saying something like :Contact Splunk support if you use this receiver" without mentioning any replacement