-
Notifications
You must be signed in to change notification settings - Fork 173
OTL-3623 Deprecate script receiver #6893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6893 +/- ##
==========================================
- Coverage 30.61% 30.41% -0.20%
==========================================
Files 367 367
Lines 25743 25744 +1
==========================================
- Hits 7880 7831 -49
- Misses 17249 17294 +45
- Partials 614 619 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crobert-1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds a deprecation doc, but there aren't any links included to it. I assume we should add links to make it easier to find?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a bit confused by this guide, but I also don't have any experience with this receiver, so my questions and confusion may be totally off here. The receiver only supports logs, but the replacement guidance is to use a metrics receiver instead, will that provide the equivalent functionality here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crobert-1 Can you suggest the alternative replacement guidance .
@dmitryax Can you confirm that the replacement guidance to use metric receiver is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @crobert-1 , the hostmetrics receiver is not a replacement because it sends metrics.
@akhileshsingh85 The decision to deprecate this is made after we've confirmed that no customer is using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can just deprecate it with messaging saying something like :Contact Splunk support if you use this receiver" without mentioning any replacement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @crobert-1 , the hostmetrics receiver is not a replacement because it sends metrics.
@akhileshsingh85 The decision to deprecate this is made after we've confirmed that no customer is using it.
Updated the docs to remove the replacement statement.
Description: Deprecate script receiver
Documentation: Update script receiver docs with deprecation notice.