Skip to content

Conversation

@akhileshsingh85
Copy link
Contributor

@akhileshsingh85 akhileshsingh85 commented Nov 3, 2025

Description: Deprecate script receiver

Documentation: Update script receiver docs with deprecation notice.

@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 30.41%. Comparing base (b7cb04d) to head (7a0e548).

Files with missing lines Patch % Lines
...ternal/receiver/scriptedinputsreceiver/operator.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6893      +/-   ##
==========================================
- Coverage   30.61%   30.41%   -0.20%     
==========================================
  Files         367      367              
  Lines       25743    25744       +1     
==========================================
- Hits         7880     7831      -49     
- Misses      17249    17294      +45     
- Partials      614      619       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@akhileshsingh85 akhileshsingh85 marked this pull request as ready for review November 3, 2025 23:46
@akhileshsingh85 akhileshsingh85 requested review from a team as code owners November 3, 2025 23:46
@akhileshsingh85 akhileshsingh85 marked this pull request as draft November 3, 2025 23:48
@akhileshsingh85 akhileshsingh85 marked this pull request as ready for review November 4, 2025 00:00
Copy link
Contributor

@crobert-1 crobert-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds a deprecation doc, but there aren't any links included to it. I assume we should add links to make it easier to find?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused by this guide, but I also don't have any experience with this receiver, so my questions and confusion may be totally off here. The receiver only supports logs, but the replacement guidance is to use a metrics receiver instead, will that provide the equivalent functionality here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crobert-1 Can you suggest the alternative replacement guidance .

@dmitryax Can you confirm that the replacement guidance to use metric receiver is correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @crobert-1 , the hostmetrics receiver is not a replacement because it sends metrics.
@akhileshsingh85 The decision to deprecate this is made after we've confirmed that no customer is using it.

Copy link
Contributor

@dmitryax dmitryax Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can just deprecate it with messaging saying something like :Contact Splunk support if you use this receiver" without mentioning any replacement

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @crobert-1 , the hostmetrics receiver is not a replacement because it sends metrics.
@akhileshsingh85 The decision to deprecate this is made after we've confirmed that no customer is using it.

@akhileshsingh85 akhileshsingh85 dismissed dloucasfx’s stale review November 13, 2025 18:33

Updated the docs to remove the replacement statement.

@akhileshsingh85 akhileshsingh85 merged commit 03f87ee into main Nov 13, 2025
231 of 237 checks passed
@akhileshsingh85 akhileshsingh85 deleted the deprecate-script-receiver branch November 13, 2025 18:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants