-
Notifications
You must be signed in to change notification settings - Fork 173
[gateway] Remove signalfx receiver from gateway configs #6887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gateway] Remove signalfx receiver from gateway configs #6887
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6887 +/- ##
==========================================
+ Coverage 37.95% 37.96% +0.01%
==========================================
Files 367 367
Lines 25743 25743
==========================================
+ Hits 9770 9774 +4
+ Misses 15161 15159 -2
+ Partials 812 810 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the SignalFx receiver with an HTTP forwarder extension in the default gateway configuration. This is a breaking change that removes the SignalFx receiver from pipelines and introduces a new http_forwarder/signalfx extension to handle SignalFx format data.
- Removed the
signalfxreceiver from the gateway configurations - Added
http_forwarder/signalfxextension to forward SignalFx format data - Removed
logs/signalfxpipeline from all configurations - Removed
signalfxreceiver from the metrics pipeline
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/general/default_config_test.go | Updated test expectations to reflect new extension and removed SignalFx receiver/pipeline |
| packaging/technical-addon/Splunk_TA_otel/configs/ta-gateway-config.yaml | Added http_forwarder/signalfx extension, removed signalfx receiver and logs/signalfx pipeline |
| deployments/nomad/otel-gateway.nomad | Added http_forwarder/signalfx extension with include_metadata, removed signalfx receiver and logs/signalfx pipeline |
| cmd/otelcol/fips/config/gateway_config.yaml | Added http_forwarder/signalfx extension, removed signalfx receiver, logs/signalfx pipeline, and exporter comments |
| cmd/otelcol/config/collector/gateway_config.yaml | Added http_forwarder/signalfx extension, removed signalfx receiver, logs/signalfx pipeline, and exporter comments |
| .chloggen/remove_sfx_receiver_gateway.yaml | Added changelog entry documenting the breaking change |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add missing extension to default Nomad gateway config - Fix indentation in default gateway config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
packaging/technical-addon/Splunk_TA_otel/configs/ta-gateway-config.yaml:138
- The service extensions list was not updated to include the new
http_forwarder/signalfxextension. This means the extension is configured but won't be active, breaking SignalFx data forwarding. Addhttp_forwarder/signalfxto the extensions list.
extensions: [headers_setter, health_check, http_forwarder, zpages]
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The comments in the agent config has to be updated as well
dmitryax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Follow up to #6837, remove the
signalfxreceiver from default gateway configurations.