Skip to content

Conversation

@crobert-1
Copy link
Contributor

@crobert-1 crobert-1 commented Oct 29, 2025

Description:

Follow up to #6837, remove the signalfx receiver from default gateway configurations.

@codecov
Copy link

codecov bot commented Oct 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 37.96%. Comparing base (ae441c4) to head (609aae0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6887      +/-   ##
==========================================
+ Coverage   37.95%   37.96%   +0.01%     
==========================================
  Files         367      367              
  Lines       25743    25743              
==========================================
+ Hits         9770     9774       +4     
+ Misses      15161    15159       -2     
+ Partials      812      810       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crobert-1 crobert-1 marked this pull request as ready for review October 30, 2025 22:30
@crobert-1 crobert-1 requested a review from a team as a code owner October 30, 2025 22:30
Copilot AI review requested due to automatic review settings October 30, 2025 22:30
@crobert-1 crobert-1 requested review from a team as code owners October 30, 2025 22:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the SignalFx receiver with an HTTP forwarder extension in the default gateway configuration. This is a breaking change that removes the SignalFx receiver from pipelines and introduces a new http_forwarder/signalfx extension to handle SignalFx format data.

  • Removed the signalfx receiver from the gateway configurations
  • Added http_forwarder/signalfx extension to forward SignalFx format data
  • Removed logs/signalfx pipeline from all configurations
  • Removed signalfx receiver from the metrics pipeline

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/general/default_config_test.go Updated test expectations to reflect new extension and removed SignalFx receiver/pipeline
packaging/technical-addon/Splunk_TA_otel/configs/ta-gateway-config.yaml Added http_forwarder/signalfx extension, removed signalfx receiver and logs/signalfx pipeline
deployments/nomad/otel-gateway.nomad Added http_forwarder/signalfx extension with include_metadata, removed signalfx receiver and logs/signalfx pipeline
cmd/otelcol/fips/config/gateway_config.yaml Added http_forwarder/signalfx extension, removed signalfx receiver, logs/signalfx pipeline, and exporter comments
cmd/otelcol/config/collector/gateway_config.yaml Added http_forwarder/signalfx extension, removed signalfx receiver, logs/signalfx pipeline, and exporter comments
.chloggen/remove_sfx_receiver_gateway.yaml Added changelog entry documenting the breaking change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Add missing extension to default Nomad gateway config
- Fix indentation in default gateway config
Copilot AI review requested due to automatic review settings October 31, 2025 18:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

packaging/technical-addon/Splunk_TA_otel/configs/ta-gateway-config.yaml:138

  • The service extensions list was not updated to include the new http_forwarder/signalfx extension. This means the extension is configured but won't be active, breaking SignalFx data forwarding. Add http_forwarder/signalfx to the extensions list.
  extensions: [headers_setter, health_check, http_forwarder, zpages]

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dmitryax
dmitryax previously approved these changes Oct 31, 2025
@dmitryax dmitryax dismissed their stale review October 31, 2025 19:45

The comments in the agent config has to be updated as well

Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjanotti pjanotti merged commit 2c59550 into signalfx:main Nov 17, 2025
238 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants