-
Notifications
You must be signed in to change notification settings - Fork 173
[receiver/signalfx] Remove from default configurations (excluding gateways) #6837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[receiver/signalfx] Remove from default configurations (excluding gateways) #6837
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6837 +/- ##
==========================================
+ Coverage 43.35% 43.43% +0.07%
==========================================
Files 370 370
Lines 26104 26104
==========================================
+ Hits 11317 11337 +20
+ Misses 13963 13947 -16
+ Partials 824 820 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the SignalFx receiver from default OpenTelemetry Collector configurations as part of a larger effort to move away from using the SignalFx receiver. The change affects multiple configuration files by removing SignalFx receiver definitions and updating pipeline configurations to use OTLP instead.
- Removes SignalFx receiver configurations from all default config files
- Updates pipeline receiver lists to exclude SignalFx and use OTLP format instead
- Adds changelog entry documenting this breaking change
Reviewed Changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/general/default_config_test.go | Updates test configuration to remove SignalFx receiver references |
| packaging/tests/instrumentation/config.yaml | Removes SignalFx receiver and updates metrics pipeline |
| packaging/tests/custom-config.yaml | Removes SignalFx receiver and updates metrics pipeline |
| packaging/technical-addon/pkg/splunk_ta_otel_linux_autoinstrumentation/runner/internal/testdata/happypath/local/ta-agent-config.yaml | Removes SignalFx receiver configuration and updates pipeline references |
| packaging/technical-addon/Splunk_TA_otel/configs/ta-agent-to-gateway-config.yaml | Removes SignalFx receiver configuration and updates pipeline references |
| packaging/technical-addon/Splunk_TA_otel/configs/ta-agent-config.yaml | Removes SignalFx receiver configuration and updates pipeline references |
| cmd/otelcol/fips/config/otlp_config_linux.yaml | Removes SignalFx receiver and entire logs pipeline |
| cmd/otelcol/fips/config/fargate_config.yaml | Removes SignalFx receiver configuration and updates metrics pipeline |
| cmd/otelcol/fips/config/ecs_ec2_config.yaml | Removes SignalFx receiver configuration and updates metrics pipeline |
| cmd/otelcol/fips/config/agent_config.yaml | Removes SignalFx receiver and logs/signalfx pipeline |
| cmd/otelcol/config/collector/upstream_agent_config.yaml | Removes SignalFx receiver and logs/signalfx pipeline |
| cmd/otelcol/config/collector/otlp_config_linux.yaml | Removes SignalFx receiver and entire logs pipeline |
| cmd/otelcol/config/collector/full_config_linux.yaml | Removes SignalFx receiver configuration and logs/signalfx pipeline |
| cmd/otelcol/config/collector/fargate_config.yaml | Removes SignalFx receiver configuration and updates metrics pipeline |
| cmd/otelcol/config/collector/ecs_ec2_config.yaml | Removes SignalFx receiver configuration and updates metrics pipeline |
| cmd/otelcol/config/collector/agent_config.yaml | Removes SignalFx receiver configuration and updates pipeline references |
| .chloggen/remove_signalfx_receiver_from_pipelines.yaml | Adds changelog entry documenting the breaking change |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dloucasfx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good, but I have one question regarding older sfx instrumentation.
Do we know if users totally moved away from SFX Instrumentation Libraries ? I just want to make sure that nothing is still sending data in SFX protobuf format
Check with the instrumentation team and confirmed that we only support OTEL instrumentation, so we should be good. |
Description:
Part of a larger effort to move away from using the SignalFx receiver.