Skip to content

Conversation

@crobert-1
Copy link
Contributor

@crobert-1 crobert-1 commented Oct 13, 2025

Description:

Part of a larger effort to move away from using the SignalFx receiver.

@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.43%. Comparing base (15602fb) to head (7e4ce81).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6837      +/-   ##
==========================================
+ Coverage   43.35%   43.43%   +0.07%     
==========================================
  Files         370      370              
  Lines       26104    26104              
==========================================
+ Hits        11317    11337      +20     
+ Misses      13963    13947      -16     
+ Partials      824      820       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crobert-1 crobert-1 marked this pull request as ready for review October 14, 2025 17:44
@crobert-1 crobert-1 requested review from a team as code owners October 14, 2025 17:44
Copilot AI review requested due to automatic review settings October 14, 2025 17:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the SignalFx receiver from default OpenTelemetry Collector configurations as part of a larger effort to move away from using the SignalFx receiver. The change affects multiple configuration files by removing SignalFx receiver definitions and updating pipeline configurations to use OTLP instead.

  • Removes SignalFx receiver configurations from all default config files
  • Updates pipeline receiver lists to exclude SignalFx and use OTLP format instead
  • Adds changelog entry documenting this breaking change

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/general/default_config_test.go Updates test configuration to remove SignalFx receiver references
packaging/tests/instrumentation/config.yaml Removes SignalFx receiver and updates metrics pipeline
packaging/tests/custom-config.yaml Removes SignalFx receiver and updates metrics pipeline
packaging/technical-addon/pkg/splunk_ta_otel_linux_autoinstrumentation/runner/internal/testdata/happypath/local/ta-agent-config.yaml Removes SignalFx receiver configuration and updates pipeline references
packaging/technical-addon/Splunk_TA_otel/configs/ta-agent-to-gateway-config.yaml Removes SignalFx receiver configuration and updates pipeline references
packaging/technical-addon/Splunk_TA_otel/configs/ta-agent-config.yaml Removes SignalFx receiver configuration and updates pipeline references
cmd/otelcol/fips/config/otlp_config_linux.yaml Removes SignalFx receiver and entire logs pipeline
cmd/otelcol/fips/config/fargate_config.yaml Removes SignalFx receiver configuration and updates metrics pipeline
cmd/otelcol/fips/config/ecs_ec2_config.yaml Removes SignalFx receiver configuration and updates metrics pipeline
cmd/otelcol/fips/config/agent_config.yaml Removes SignalFx receiver and logs/signalfx pipeline
cmd/otelcol/config/collector/upstream_agent_config.yaml Removes SignalFx receiver and logs/signalfx pipeline
cmd/otelcol/config/collector/otlp_config_linux.yaml Removes SignalFx receiver and entire logs pipeline
cmd/otelcol/config/collector/full_config_linux.yaml Removes SignalFx receiver configuration and logs/signalfx pipeline
cmd/otelcol/config/collector/fargate_config.yaml Removes SignalFx receiver configuration and updates metrics pipeline
cmd/otelcol/config/collector/ecs_ec2_config.yaml Removes SignalFx receiver configuration and updates metrics pipeline
cmd/otelcol/config/collector/agent_config.yaml Removes SignalFx receiver configuration and updates pipeline references
.chloggen/remove_signalfx_receiver_from_pipelines.yaml Adds changelog entry documenting the breaking change

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@dloucasfx dloucasfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but I have one question regarding older sfx instrumentation.
Do we know if users totally moved away from SFX Instrumentation Libraries ? I just want to make sure that nothing is still sending data in SFX protobuf format

@dloucasfx
Copy link
Contributor

The changes look good, but I have one question regarding older sfx instrumentation. Do we know if users totally moved away from SFX Instrumentation Libraries ? I just want to make sure that nothing is still sending data in SFX protobuf format

Check with the instrumentation team and confirmed that we only support OTEL instrumentation, so we should be good.
Thanks !

@crobert-1 crobert-1 merged commit 091c7ef into signalfx:main Oct 16, 2025
315 checks passed
@crobert-1 crobert-1 deleted the remove_signalfx_receiver_from_pipelines branch October 16, 2025 17:32
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants