Skip to content

[ansible] Add option to set service CLI args #6270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2025

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented May 30, 2025

Adds a specific option to set the command-line arguments used to launch the collector service on Linux - Windows implementation is coming after #6268 is released.

The test for this new config setting is piggy-backing on the test for custom environment variables due to the similarities and to avoid yet another test for some CI that is already relatively long to run.

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.90%. Comparing base (44069e4) to head (856c77c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6270      +/-   ##
==========================================
+ Coverage   44.88%   44.90%   +0.02%     
==========================================
  Files         390      390              
  Lines       26994    26994              
==========================================
+ Hits        12115    12122       +7     
+ Misses      14012    14006       -6     
+ Partials      867      866       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pjanotti pjanotti changed the title [DRAFT][ansible] Add option to set service cli args [ansible] Add option to set service CLI args Jun 2, 2025
@pjanotti pjanotti marked this pull request as ready for review June 2, 2025 20:52
@pjanotti pjanotti requested review from a team as code owners June 2, 2025 20:52
@pjanotti pjanotti merged commit d99d856 into signalfx:main Jun 3, 2025
124 of 127 checks passed
@pjanotti pjanotti deleted the ansible-add-custom-cmd-line branch June 3, 2025 19:11
@github-actions github-actions bot locked and limited conversation to collaborators Jun 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants