Skip to content

[msi] Add option to set collector service CLI args #6268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 2, 2025

Conversation

pjanotti
Copy link
Contributor

@pjanotti pjanotti commented May 30, 2025

Add an install property, COLLECTOR_SVC_ARGS, to be used to specify the command-line arguments to be passed to the collector when launching the collector service on Windows.

Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.89%. Comparing base (776133a) to head (f1bc944).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6268   +/-   ##
=======================================
  Coverage   44.89%   44.89%           
=======================================
  Files         390      390           
  Lines       26994    26994           
=======================================
  Hits        12119    12119           
  Misses      14008    14008           
  Partials      867      867           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pjanotti pjanotti changed the title [DRAFT] Add support to customer args to MSI [DRAFT][msi] Add option to set collector service CLI args May 30, 2025
@pjanotti pjanotti marked this pull request as ready for review May 30, 2025 19:53
@pjanotti pjanotti requested review from a team as code owners May 30, 2025 19:53
@pjanotti pjanotti changed the title [DRAFT][msi] Add option to set collector service CLI args [msi] Add option to set collector service CLI args May 30, 2025
Copy link
Contributor

@jvoravong jvoravong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The lychee link check failures are fixed in main and can be ignored in this PR.

@pjanotti pjanotti merged commit 602f284 into signalfx:main Jun 2, 2025
189 of 190 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants