[receiver/discovery] Send delete entity events for discovered services #6260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6260 +/- ##
==========================================
+ Coverage 44.89% 44.92% +0.03%
==========================================
Files 390 390
Lines 27006 26994 -12
==========================================
+ Hits 12123 12127 +4
+ Misses 14013 14003 -10
+ Partials 870 864 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dmitryax
force-pushed
the
fix-discovery-service-delete-events
branch
5 times, most recently
from
adeaf5d to
256ec49
Compare
Send delete entity events once discovered services are removed to keep the "discovered services" view up-to-date. This change requires pulling the upstream bugfix open-telemetry/opentelemetry-collector-contrib#40279. This also moves service.name and service.type attributes to the set of identifying attributes according to the entity definition in the inventory service.
dmitryax
force-pushed
the
fix-discovery-service-delete-events
branch
from
256ec49 to
925f397
Compare
jvoravong
approved these changes
May 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Send delete entity events once discovered services are removed to keep the "discovered services" view up-to-date.
This change requires pulling the upstream bugfix open-telemetry/opentelemetry-collector-contrib#40279.
This also moves service.name and service.type attributes to the set of identifying attributes according to the entity definition in the inventory service.