Skip to content

[discovery] Enable more metrics by default for SQL Server receiver #6259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

crobert-1
Copy link
Contributor

Description:

This is to match out of the box content.

Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.90%. Comparing base (602f284) to head (df6531c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6259      +/-   ##
==========================================
+ Coverage   44.89%   44.90%   +0.01%     
==========================================
  Files         390      390              
  Lines       26994    26994              
==========================================
+ Hits        12119    12122       +3     
+ Misses      14008    14006       -2     
+ Partials      867      866       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@crobert-1 crobert-1 marked this pull request as ready for review May 28, 2025 23:03
@crobert-1 crobert-1 requested review from a team as code owners May 28, 2025 23:03
Copy link
Contributor

@jvoravong jvoravong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The lychee link check failures are fixed in main and can be ignored in this PR. Looks like some simple merge conflicts need to be addressed.

@crobert-1 crobert-1 merged commit 44069e4 into signalfx:main Jun 2, 2025
35 of 36 checks passed
@crobert-1 crobert-1 deleted the update_sqlserver_discovery_config branch June 2, 2025 20:46
@github-actions github-actions bot locked and limited conversation to collaborators Jun 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants