Skip to content

keep histograms in envoy prometheus receiver #6243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025
Merged

keep histograms in envoy prometheus receiver #6243

merged 2 commits into from
May 21, 2025

Conversation

jinja2
Copy link
Contributor

@jinja2 jinja2 commented May 21, 2025

Description:

The current config for prometheus receiver for Envoy in discovery mode is not matching with histogram metrics. This PR updates the config to additional keep metrics which match with the histogram suffixes.

Testing:
Update the tests with histogram metrics received

@jinja2 jinja2 requested review from a team as code owners May 21, 2025 01:56
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.84%. Comparing base (cac6324) to head (c1b8a22).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6243      +/-   ##
==========================================
- Coverage   44.88%   44.84%   -0.05%     
==========================================
  Files         390      390              
  Lines       26983    26983              
==========================================
- Hits        12112    12100      -12     
- Misses      14003    14013      +10     
- Partials      868      870       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jinja2 jinja2 force-pushed the fix-envoy-rules branch from a5b1857 to 05c729b Compare May 21, 2025 15:54
@jinja2 jinja2 merged commit 6dff418 into main May 21, 2025
233 checks passed
@jinja2 jinja2 deleted the fix-envoy-rules branch May 21, 2025 18:13
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants