[technial-addons] general enhancements to addon packaging framework #6219
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6219 +/- ##
==========================================
- Coverage 44.41% 44.36% -0.05%
==========================================
Files 390 390
Lines 26986 26986
==========================================
- Hits 11985 11973 -12
- Misses 14158 14167 +9
- Partials 843 846 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hughesjj
force-pushed
the
ta-framework-refactor-enhancements
branch
8 times, most recently
from
1a58614 to
52bddca
Compare
multiple addons to be included in splunk startup
hughesjj
force-pushed
the
ta-framework-refactor-enhancements
branch
from
52bddca to
e697345
Compare
| splunkStartURL := strings.Join(addonNames, ",") | ||
| t.Logf("Splunk start url: %s", splunkStartURL) | ||
| req := testcontainers.ContainerRequest{ | ||
| Image: "splunk/splunk:9.4.1", |
There was a problem hiding this comment.
Can you try to get this image reference in a location where CI/CD or dependabot can update it over time?
There was a problem hiding this comment.
I'll just switch to latest
|
Nit: In the future, consider reviewing and updating the usage of Go caches in the TA workflows. Some logs suggest we are writing to the Go cache during action runs but not consistently reading or utilizing the cache entries where possible. While not a blocker for these changes, keeping the runtime for these workflows lower helps everyone. Log References: |
Co-authored-by: jvoravong <[email protected]>
Makes addon generation more generic, adds more tests, and allows for multiple addons to be included in splunk startup