Rework TA makefiles

[hughesjj]

This is some clean up, also adds target for new makefiles

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.40%. Comparing base (3dac036) to head (6005fb5).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6203      +/-   ##
==========================================
- Coverage   44.41%   44.40%   -0.02%     
==========================================
  Files         390      390              
  Lines       26986    26986              
==========================================
- Hits        11985    11982       -3     
- Misses      14158    14160       +2     
- Partials      843      844       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[crobert-1]

Mostly questions as I'm not very familiar with TA logic and what's being changed here 👍

[crobert-1]

I'm seeing a common pattern in this Makefile is to have commands setting variables at the end. What is the value and purpose of this? Is AUTOINSTRUMENTATION_DIR going to be used after this for something else?

[hughesjj]

Removed as not needed until next review, but yes

[hughesjj]

I don't believe the one failure is related to this test, given it's for ARM

2025/05/14 17:14:05 🐳 Creating container for image 6590270a-80d1-4b3a-a1c6-a57068c7454f:b5345fe9-8a3c-40ed-b43f-1a65096dda82
2025/05/14 17:14:05 ⏳ Waiting for Reaper "f67eda8a" to be ready
2025/05/14 17:14:05 🔥 Reaper obtained from Docker for this test session f67eda8a
2025/05/14 17:14:05 ✅ Container created: ee05dbc84354
2025/05/14 17:14:05 🐳 Starting container: ee05dbc84354
2025/05/14 17:14:05 ✅ Container started: ee05dbc84354
2025/05/14 17:14:05 ⏳ Waiting for container id ee05dbc84354 image: 6590270a-80d1-4b3a-a1c6-a57068c7454f:b5345fe9-8a3c-40ed-b43f-1a65096dda82. Waiting for: &{timeout:<nil> deadline:0xc000245fd8 Strategies:[0xc000259f20]}
2025/05/14 17:14:07 container logs (wait until ready: container exited with code 1):
2025/05/14 17:14:07 settings.go:478: Set config to [/etc/config.yaml]
2025/05/14 17:14:07 settings.go:539: Set memory limit to 460 MiB
2025/05/14 17:14:07 settings.go:524: Set soft memory limit set to 460 MiB
2025/05/14 17:14:07 settings.go:373: Set garbage collection target percentage (GOGC) to 400
2025/05/14 17:14:07 settings.go:414: set "SPLUNK_LISTEN_INTERFACE" to "0.0.0.0"
2025-05-14T17:14:07.137Z	info	[email protected]/service.go:199	Setting up own telemetry...
2025-05-14T17:14:07.184Z	info	[email protected]/service.go:266	Starting otelcol...	{"Version": "v0.125.0-11-g446ca992", "NumCPU": 4}
2025-05-14T17:14:07.184Z	info	extensions/extensions.go:41	Starting extensions...
2025-05-14T17:14:07.242Z	info	[email protected]/receiver.go:204	Configuring collectd	{"otelcol.component.id": "smartagent/collectd_solr", "otelcol.component.kind": "receiver", "otelcol.signal": "metrics"}
2025-05-14T17:14:07.245Z	info	collectd/collectd.go:379	Started collectd write server	{"otelcol.component.id": "smartagent/collectd_solr", "otelcol.component.kind": "receiver", "otelcol.signal": "metrics", "name": "default", "collectdInstance": "global", "ipAddr": "127.9.8.7", "port": 41601}
2025-05-14T17:14:07.267Z	info	subproc/core.go:108	Started subprocess runner	{"otelcol.component.id": "smartagent/collectd_solr", "otelcol.component.kind": "receiver", "otelcol.signal": "metrics", "monitorID": "smartagentcollectd_solr", "monitorType": "collectd/solr", "runnerPID": 14}
2025-05-14T17:14:07.273Z	error	subproc/core.go:113	qemu-aarch64: Could not open '/bin/ld-linux.so': No such file or directory	{"otelcol.component.id": "smartagent/collectd_solr", "otelcol.component.kind": "receiver", "otelcol.signal": "metrics", "monitorID": "smartagentcollectd_solr", "monitorType": "collectd/solr", "runnerPID": 14}
2025-05-14T17:14:07.277Z	error	subproc/core.go:159	Subprocess monitor runner shutdown with error	{"otelcol.component.id": "smartagent/collectd_solr", "otelcol.component.kind": "receiver", "otelcol.signal": "metrics", "error": "exit status 255", "monitorID": "smartagentcollectd_solr", "monitorType": "collectd/solr", "runnerPID": 14}
2025-05-14T17:14:07.279Z	error	subproc/core.go:144	Could not configure subprocess monitor	{"otelcol.component.id": "smartagent/collectd_solr", "otelcol.component.kind": "receiver", "otelcol.signal": "metrics", "error": "EOF", "monitorID": "smartagentcollectd_solr", "monitorType": "collectd/solr", "runnerPID": 14}
2025-05-14T17:14:07.281Z	error	graph/graph.go:438	Failed to start component	{"error": "EOF", "type": "Receiver", "id": "smartagent/collectd_solr"}
2025-05-14T17:14:07.281Z	info	[email protected]/service.go:331	Starting shutdown...
2025-05-14T17:14:07.292Z	info	extensions/extensions.go:69	Stopping extensions...
2025-05-14T17:14:07.292Z	info	[email protected]/service.go:345	Shutdown complete.
Error: cannot start pipelines: failed to start "smartagent/collectd_solr" receiver: EOF
2025/05/14 17:14:07 main.go:92: application run finished with error: cannot start pipelines: failed to start "smartagent/collectd_solr" receiver: EOF

    golden.go:131: 
        	Error Trace:	/home/runner/work/splunk-otel-collector/splunk-otel-collector/tests/testutils/golden.go:131
        	            				/home/runner/work/splunk-otel-collector/splunk-otel-collector/tests/receivers/smartagent/collectd-solr/collectd_solr_test.go:28
        	Error:      	Received unexpected error:
        	            	start container: started hook: wait until ready: container exited with code 1
        	Test:       	TestCollectdSolrReceiverProvidesAllMetrics