[chore][codecov] Add code coverage results for remaining workflows #6049
Conversation
crobert-1
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6049 +/- ##
==========================================
- Coverage 55.36% 54.33% -1.03%
==========================================
Files 220 190 -30
Lines 15407 13366 -2041
==========================================
- Hits 8530 7263 -1267
+ Misses 6393 5676 -717
+ Partials 484 427 -57 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Note: Code coverage from this change has dropped so far as now python code files are considered in the total of lines in the project, when initially they weren't. |
crobert-1
force-pushed
the
add_integration_test_cover
branch
from
c0fb10d to
3d34a5e
Compare
| @@ -47,7 +47,7 @@ try { | |||
|
|
|||
| # Run the tests | |||
| Set-Location $repo_root/tests/zeroconfig/windows/ | |||
| go test -timeout 5m -tags zeroconfig -v | |||
| go test -timeout 5m -tags zeroconfig -v ./... -cover -covermode=atomic -coverpkg $repo_root/packaging/msi -args -test.gocoverdir="$repo_root/coverage" | |||
There was a problem hiding this comment.
There is only test code on this folder.
| @@ -51,14 +51,21 @@ jobs: | |||
| make install-tools | |||
| mkdir -p unit-test-results-${{ matrix.OS }}/junit | |||
| trap "go-junit-report -set-exit-code < unit-test-results-${{ matrix.OS }}/go-unit-tests.out > unit-test-results-${{ matrix.OS }}/junit/results.xml" EXIT | |||
| make for-all CMD="make test-without-race" | tee unit-test-results-${{ matrix.OS }}/go-unit-tests.out | |||
| make test-cover-without-race | tee unit-test-results-${{ matrix.OS }}/go-unit-tests.out | |||
There was a problem hiding this comment.
I see that the target now does ALL_PKG_DIRS, but I'm curious why.
| @@ -231,7 +239,16 @@ jobs: | |||
|
|
|||
| - name: Run the MSI tests | |||
| run: | | |||
| go test -timeout 15m -v github.com/signalfx/splunk-otel-collector/tests/msi | |||
| mkdir -p $(PWD)\coverage | |||
| go test -timeout 15m -v github.com/signalfx/splunk-otel-collector/tests/msi \ | |||
There was a problem hiding this comment.
It doesn't link directly to code being exercised, it performs the test creating processes. Do you know if it is able to capture correctly code coverage in this case? Some other languages do that, by instrumenting the code being tested, but I don't think that this can do that.
|
Closing as this work has been completed and/or isn't adding value. |
Description:
The following workflows should be included in codecov results, but are not yet:
This PR adds code coverage for each of these workflows.