-
Notifications
You must be signed in to change notification settings - Fork 166
New Azuremonitorreceiver component #4971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a435c7c
to
380fe9c
Compare
|
crobert-1
reviewed
Jun 11, 2024
380fe9c
to
46f7da2
Compare
crobert-1
reviewed
Jun 11, 2024
crobert-1
approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for your contribution here!
ac9bf79
to
31c8437
Compare
31c8437
to
1c60583
Compare
hughesjj
reviewed
Jun 11, 2024
pjanotti
approved these changes
Jun 11, 2024
The two integration tests seemed to have failed seem unrelated to this MR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Adds support for the azuremonitor receiver from the opentelemetry contrib repo.
Testing: components_test.go has been updated to reflect these changes. Local testing of the azuremonitorreceiver was also successful. We were able to scrape the azuremonitor metrics and send them to Splunk Observability.
Documentation: components.md has been updated to show the new component
Co-author: https://github.com/brendtg @brendtg