-
Notifications
You must be signed in to change notification settings - Fork 166
initial kafkametrics discovery integ test using docker_observer #4940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
473669e
to
85a2b43
Compare
@hughesjj the centos issues were known and have been resolved. If you pull the latest those integration tests will pass. |
9684d76
to
ebf2bcf
Compare
seemed to work, just rebasing to latest |
@@ -57,6 +57,34 @@ services: | |||
build: ./httpd_basicauth | |||
ports: | |||
- "8001:80" | |||
# new-style kafka | |||
kafka-kraft-single: | |||
image: apache/kafka:3.7.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should mirror this or similar in our own org's registry (quay?), but will await discussion on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is fine for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Can you rebase please?
ebf2bcf
to
0429f7f
Compare
0429f7f
to
3204dab
Compare
3204dab
to
57351ea
Compare
Adds an integration smoke test for kafkametrics discovery similar to how we currently do it for mongodb