Skip to content

initial kafkametrics discovery integ test using docker_observer #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

hughesjj
Copy link
Contributor

@hughesjj hughesjj commented Jun 4, 2024

Adds an integration smoke test for kafkametrics discovery similar to how we currently do it for mongodb

@hughesjj hughesjj force-pushed the kafka_integ_test_discovery branch 5 times, most recently from 473669e to 85a2b43 Compare June 5, 2024 00:00
@samiura
Copy link

samiura commented Jun 7, 2024

@hughesjj the centos issues were known and have been resolved. If you pull the latest those integration tests will pass.

@hughesjj hughesjj force-pushed the kafka_integ_test_discovery branch from 9684d76 to ebf2bcf Compare June 11, 2024 22:30
@hughesjj
Copy link
Contributor Author

seemed to work, just rebasing to latest main to see if it fixes any of the unrelated test failures

@hughesjj hughesjj marked this pull request as ready for review June 11, 2024 22:32
@hughesjj hughesjj requested review from a team as code owners June 11, 2024 22:32
@@ -57,6 +57,34 @@ services:
build: ./httpd_basicauth
ports:
- "8001:80"
# new-style kafka
kafka-kraft-single:
image: apache/kafka:3.7.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should mirror this or similar in our own org's registry (quay?), but will await discussion on that

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fine for now.

Copy link

@samiura samiura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you rebase please?

@hughesjj hughesjj force-pushed the kafka_integ_test_discovery branch from ebf2bcf to 0429f7f Compare June 12, 2024 17:16
@samiura samiura force-pushed the kafka_integ_test_discovery branch from 0429f7f to 3204dab Compare June 12, 2024 17:48
@hughesjj hughesjj force-pushed the kafka_integ_test_discovery branch from 3204dab to 57351ea Compare June 12, 2024 21:53
@hughesjj hughesjj merged commit 2b9de81 into main Jun 12, 2024
123 checks passed
@hughesjj hughesjj deleted the kafka_integ_test_discovery branch June 12, 2024 22:15
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants