[chore][chef] Fix lint failures (#6237)

* [chore][chef] Fix lint failures

* Upgrade required node version

Author: crobert-1

deployments/chef/attributes/default.rb

@@ -17,7 +17,7 @@
 default['splunk_otel_collector']['splunk_api_url'] = "https://api.#{node['splunk_otel_collector']['splunk_realm']}.signalfx.com"
 default['splunk_otel_collector']['splunk_ingest_url'] = "https://ingest.#{node['splunk_otel_collector']['splunk_realm']}.signalfx.com"
 default['splunk_otel_collector']['splunk_hec_url'] = "#{node['splunk_otel_collector']['splunk_ingest_url']}/v1/log"
-default['splunk_otel_collector']['splunk_hec_token'] = "#{node['splunk_otel_collector']['splunk_access_token']}"
+default['splunk_otel_collector']['splunk_hec_token'] = node['splunk_otel_collector']['splunk_access_token'].to_s
 default['splunk_otel_collector']['splunk_memory_total_mib'] = '512'
 default['splunk_otel_collector']['gomemlimit'] = ''
 default['splunk_otel_collector']['splunk_listen_interface'] = ''

deployments/chef/kitchen.yml

@@ -101,7 +101,7 @@ suites:
     attributes:
       nodejs: &nodejs_options
         install_method: binary
-        version: 16.20.2
+        version: 18.20.8
         binary:
           append_env_path: false  # required for idempotence
           checksum: c9193e6c414891694759febe846f4f023bf48410a6924a8b1520c46565859665

deployments/chef/recipes/auto_instrumentation.rb

@@ -62,7 +62,7 @@
   options '--allow-downgrades' if platform_family?('debian') \
     && node['packages'] \
     && node['packages']['apt'] \
-    && Gem::Version.new(node['packages']['apt']['version'].split('~')[0]) >= Gem::Version.new('1.1.0')
+    && Gem::Version.new(node['packages']['apt']['version'].split('~').first) >= Gem::Version.new('1.1.0')
   allow_downgrade true if platform_family?('amazon', 'rhel', 'suse')
   notifies :reload, 'ohai[reload packages]', :immediately
   notifies :run, 'ruby_block[install splunk-otel-js]', :immediately

deployments/chef/recipes/default.rb

@@ -29,7 +29,7 @@
   end
 
   remote_file node['splunk_otel_collector']['collector_config_dest'] do
-    source "#{node['splunk_otel_collector']['collector_config_source']}"
+    source node['splunk_otel_collector']['collector_config_source'].to_s
     only_if { ::File.exist?(node['splunk_otel_collector']['collector_config_source']) && node['splunk_otel_collector']['collector_config'] == {} }
     notifies :restart, 'windows_service[splunk-otel-collector]', :delayed
   end
@@ -61,7 +61,7 @@
     options '--allow-downgrades' if platform_family?('debian') \
       && node['packages'] \
       && node['packages']['apt'] \
-      && Gem::Version.new(node['packages']['apt']['version'].split('~')[0]) >= Gem::Version.new('1.1.0')
+      && Gem::Version.new(node['packages']['apt']['version'].split('~').first) >= Gem::Version.new('1.1.0')
     allow_downgrade true if platform_family?('amazon', 'rhel', 'suse')
     notifies :restart, 'service[splunk-otel-collector]', :delayed
   end
@@ -82,7 +82,7 @@
   end
 
   remote_file node['splunk_otel_collector']['collector_config_dest'] do
-    source "#{node['splunk_otel_collector']['collector_config_source']}"
+    source node['splunk_otel_collector']['collector_config_source'].to_s
     owner node['splunk_otel_collector']['user']
     group node['splunk_otel_collector']['group']
     mode '0600'

deployments/chef/recipes/fluentd_deb_repo.rb

@@ -1,7 +1,7 @@
 # Cookbook:: splunk_otel_collector
 # Recipe:: fluentd_deb_repo
 
-td_agent_major_version = node['splunk_otel_collector']['fluentd_version'].split('.')[0]
+td_agent_major_version = node['splunk_otel_collector']['fluentd_version'].split('.').first
 codename = node['lsb']['codename']
 distro = node['platform']
 

deployments/chef/recipes/fluentd_linux_install.rb

@@ -8,7 +8,7 @@
   options '--allow-downgrades' if platform_family?('debian') \
     && node['packages'] \
     && node['packages']['apt'] \
-    && Gem::Version.new(node['packages']['apt']['version'].split('~')[0]) >= Gem::Version.new('1.1.0')
+    && Gem::Version.new(node['packages']['apt']['version'].split('~').first) >= Gem::Version.new('1.1.0')
 
   allow_downgrade true if platform_family?('rhel', 'amazon')
   notifies :restart, 'service[td-agent]', :delayed
@@ -64,7 +64,7 @@
 end
 
 remote_file node['splunk_otel_collector']['fluentd_config_dest'] do
-  source "#{node['splunk_otel_collector']['fluentd_config_source']}"
+  source node['splunk_otel_collector']['fluentd_config_source'].to_s
   owner 'td-agent'
   group 'td-agent'
   mode '0644'

deployments/chef/recipes/fluentd_win_install.rb

@@ -1,7 +1,7 @@
 # Cookbook:: splunk_otel_collector
 # Recipe:: fluentd_win_install
 
-td_agent_major_version = node['splunk_otel_collector']['fluentd_version'].split('.')[0]
+td_agent_major_version = node['splunk_otel_collector']['fluentd_version'].split('.').first
 
 remote_file "#{ENV['TEMP']}\\td-agent-#{node['splunk_otel_collector']['fluentd_version']}-x64.msi" do
   source "#{node['splunk_otel_collector']['fluentd_base_url']}/#{td_agent_major_version}/windows/td-agent-#{node['splunk_otel_collector']['fluentd_version']}-x64.msi"
@@ -30,7 +30,7 @@
 end
 
 remote_file node['splunk_otel_collector']['fluentd_config_dest'] do
-  source "#{node['splunk_otel_collector']['fluentd_config_source']}"
+  source node['splunk_otel_collector']['fluentd_config_source'].to_s
   notifies :restart, 'windows_service[td-agent]', :delayed
 end
 

deployments/chef/recipes/fluentd_yum_repo.rb

@@ -1,7 +1,7 @@
 # Cookbook:: splunk_otel_collector
 # Recipe:: collector_yum_repo
 
-td_agent_major_version = node['splunk_otel_collector']['fluentd_version'].split('.')[0]
+td_agent_major_version = node['splunk_otel_collector']['fluentd_version'].split('.').first
 
 distro = if platform_family?('amazon')
            'amazon'