revert all windows ansible changes, handled in separate PR

Author: crobert-1

deployments/ansible/molecule/custom_vars/windows-converge.yml

@@ -8,7 +8,7 @@
     splunk_api_url: https://fake-splunk-api.com
     splunk_hec_url: https://fake-splunk-hec.com
     splunk_hec_token: fake-hec-token
-    splunk_otel_collector_version: 0.126.0
+    splunk_otel_collector_version: 0.48.0
     splunk_otel_collector_config: '{{ansible_env.ProgramData}}\Splunk\OpenTelemetry Collector\custom_config.yml'
     splunk_otel_collector_config_source: ./custom_collector_config.yml
     splunk_memory_total_mib: 256

deployments/ansible/molecule/custom_vars/windows-verify.yml

@@ -45,20 +45,20 @@
       assert:
         that: not service_status.changed
 
-    - name: Download splunk-otel-collector 0.126.0 MSI
+    - name: Download splunk-otel-collector 0.48.0 MSI
       ansible.windows.win_get_url:
-        url: https://dl.signalfx.com/splunk-otel-collector/msi/release/splunk-otel-collector-0.126.0-amd64.msi
+        url: https://dl.signalfx.com/splunk-otel-collector/msi/release/splunk-otel-collector-0.48.0-amd64.msi
         dest: "{{ansible_env.TEMP}}"
       register: otel_msi_package
 
-    - name: Install splunk-otel-collector 0.126.0 MSI
+    - name: Install splunk-otel-collector 0.48.0 MSI
       ansible.windows.win_package:
         path: "{{otel_msi_package.dest}}"
         state: present
       check_mode: yes
       register: msi_installed
 
-    - name: Assert splunk-otel-collector 0.126.0 MSI is already installed
+    - name: Assert splunk-otel-collector 0.48.0 MSI is already installed
       assert:
         that: not msi_installed.changed
 

deployments/ansible/roles/collector/tasks/otel_win_install.yml

@@ -61,16 +61,12 @@
   set_fact:
     msi_arguments: "{{ msi_unfiltered_arguments | reject('eq', '') | list }}"
 
-- debug:
-    var: msi_arguments
-
 - name: Install splunk-otel-collector-msi
   when: splunk_collector_msi_is_configurable is defined
   ansible.windows.win_package:
     path: "{{otel_msi_package.dest}}"
     state: present
-    arguments: >-
-      "{{ msi_arguments }}"
+    arguments: "{{ msi_arguments }}"
 
 - name: Install splunk-otel-collector-msi-legacy
   when: splunk_collector_msi_is_configurable is undefined