Skip to content

Prepare release v0.126.0 #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 4, 2025
Merged

Prepare release v0.126.0 #1851

merged 9 commits into from
Jun 4, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 29, 2025

Description

  • Release Helm chart version 0.126.0
  • Includes collector version 0.126.0

@github-actions github-actions bot requested review from a team as code owners May 29, 2025 01:25
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
@jvoravong
Copy link
Contributor

jvoravong commented May 29, 2025

--- FAIL: Test_ControlPlaneMetrics (60.70s)
--- FAIL: Test_ControlPlaneMetrics/kubernetes-scheduler_histograms=true (30.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference

--- FAIL: Test_IstioMetrics (112.14s)
--- FAIL: Test_IstioMetrics/istiod_metrics_captured (33.05s)
--- FAIL: Test_IstioMetrics/istio_ingress_metrics_captured (31.14s)

@github-actions github-actions bot changed the title Prepare release v0.126.0 Prepare release vnull..0 Jun 1, 2025
@github-actions github-actions bot force-pushed the update-release branch 2 times, most recently from 5b6318d to ceb3caf Compare June 1, 2025 13:06
@github-actions github-actions bot changed the title Prepare release vnull..0 Prepare release v0.126.0 Jun 1, 2025
@jvoravong
Copy link
Contributor

jvoravong commented Jun 2, 2025

Validated that Istio tests pass when agent.featureGates=-receiver.prometheusreceiver.RemoveLegacyResourceAttributes is set. The test failures are due to the promotion of this feature gate to beta (enabled by default).

To address this, we need to:

  • Regenerate the expected Istio test results with the feature gate enabled to account for breaking changes.
    • Running the tests with the env var UPDATE_EXPECTED_RESULTS can be used in github workflows or locally to generate new test results.
  • Add a breaking change entry in CHANGELOG.md and document the changes in UPGRADING.md, including instructions for configuring and using the previous functionality.
  • Ensure CHANGELOG.md links to UPGRADING.md.

References:

Signed-off-by: Maciek Stopa <[email protected]>
Signed-off-by: Maciek Stopa <[email protected]>
@jvoravong
Copy link
Contributor

When updating expected test results, try to limit changes to Istio-related files only. Avoid modifying unrelated files unless necessary—this helps keep all tests passing and preserves clean git history for easier blame tracking.

…modate initialDelaySeconds because helm fixed an issues with automatically inserting this. Ran `make render`. See: #1858
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryax dmitryax merged commit d26e04e into main Jun 4, 2025
142 of 143 checks passed
@dmitryax dmitryax deleted the update-release branch June 4, 2025 19:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants