Skip to content

Add prometheus receiver for EKS Apiserver metrics #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 28, 2025
Merged

Add prometheus receiver for EKS Apiserver metrics #1831

merged 6 commits into from
May 28, 2025

Conversation

jinja2
Copy link
Collaborator

@jinja2 jinja2 commented May 19, 2025

Description:

Introduces a featureGate enableEKSApiServerMetrics to add prometheus receiver to scrape metrics from EKS apiserver. This can be used with distribution - eks or eks/fargate. This featureGate will send histograms as OTLP histograms to Splunk Observability.

Testing:
Tested in eks and eks/fargate cluster

@jinja2 jinja2 requested review from a team as code owners May 19, 2025 14:59
@dmitryax
Copy link
Contributor

Why don't add it under the existing useControlPlaneMetricsHistogramData feature gate?

@jinja2
Copy link
Collaborator Author

jinja2 commented May 20, 2025

useControlPlaneMetricsHistogramData in its current form is used along with the agent.controlPlaneMetrics.* variables to decide if we use the old smartagent receiver or prometheus one. This new receiver is in the clusterReceiver, so reusing the variables under agent doesn't seem right. And instead of making it a variable under clusterReceiver, I opted for a featureGate due to it emitting histograms.

Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinja2
Copy link
Collaborator Author

jinja2 commented May 28, 2025

Waiting to merge this PR after which I'll enable the featuregate in eks/fargate test.

@jinja2 jinja2 merged commit 1fbd0e0 into main May 28, 2025
98 checks passed
@jinja2 jinja2 deleted the eks-recv branch May 28, 2025 17:48
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants