Skip to content

Commit 89f2ed1

Browse files
authored
deprecation of certmanager as a dependency (#1763)
* deprecate certmanager subchart * deprecate certmanager subchart * deprecate certmanager subchart * deprecate certmanager subchart
1 parent 3aecdb7 commit 89f2ed1

File tree

5 files changed

+27
-10
lines changed

5 files changed

+27
-10
lines changed

.chloggen/deprecate-certmanager.yaml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
2+
change_type: deprecation
3+
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
4+
component: chart
5+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
6+
note: Installing certmanager as part of the splunk-otel-collector helm chart is deprecated and will be removed in a future release.
7+
# One or more tracking issues related to the change
8+
issues: [1763]
9+
# (Optional) One or more lines of additional information to render under the primary note.
10+
# These lines will be padded with 2 spaces and then inserted directly into the document.
11+
# Use pipe (|) for multiline entries.
12+
subtext:

docs/auto-instrumentation-install.md

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -32,15 +32,16 @@ these frameworks often have pre-built instrumentation capabilities already avail
3232
- **Required**: This configuration is necessary for the operator's deployment within your cluster.
3333

3434
- **TLS Certificate Management (Required)**
35-
- **Using cert-manager (Recommended)**
36-
- `certmanager.enabled`: Enable cert-manager by setting to `true`.
37-
- **Check Before Enabling**: Ensure cert-manager is not already installed to avoid multiple instances.
38-
- **Recommended**: Cert-manager simplifies the management of TLS certificates, automating issuance and renewal.
35+
- **Automatically Generate a Self-Signed Certificate with Helm (Default)**
36+
- `operator.admissionWebhooks.autoGenerateCert.enabled`: Set to `true` to enable Helm to automatically create a self-signed certificate.
3937

4038
- **Alternative Methods**
41-
- **Automatically Generate a Self-Signed Certificate with Helm**
42-
- `operator.admissionWebhooks.autoGenerateCert.enabled`: Set to `true` to enable Helm to automatically create a self-signed certificate.
43-
- **Use Case**: Suitable when cert-manager is not installed or preferred.
39+
40+
- **Using cert-manager**
41+
- Use an already installed certmanager by setting `operator.admissionWebhooks.certManager.enabled` to `true`.
42+
- **Use Case**: Ideal for environments already leveraging `certmanager` for certificate management.
43+
- _NOTE_ - The option to install `certmanager` with our chart is deprecated and will be removed in future releases.
44+
4445
- **Provide Your Own Certificate**
4546
- Ensure both `operator.admissionWebhooks.certManager.enabled` and `operator.admissionWebhooks.autoGenerateCert.enabled` are set to `false`.
4647
- `operator.admissionWebhooks.cert_file`: Path to your PEM-encoded certificate.
@@ -502,7 +503,7 @@ operator:
502503
enabled: true
503504
```
504505

505-
##### Option 2: **Deploy cert-manager and the operator together**
506+
##### Option 2: **Deploy cert-manager and the operator together (Deprecated)**
506507

507508
If you need to install `cert-manager` along with the operator, use a Helm post-install or post-upgrade hook to ensure that the certificate is created after cert-manager CRDs are installed.
508509

docs/auto-instrumentation-introduction.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ When using the Splunk OTel Collector chart with the [OpenTelemetry Operator](htt
3434
### Quick Start
3535
To use auto-instrumentation via the operator, these are the high-level steps:
3636

37-
1. Deploy OpenTelemetry components to your Kubernetes cluster including cert-manager, Splunk OTel Collector, OpenTelemetry Operator, and Auto-Instrumentation Spec.
37+
1. Deploy OpenTelemetry components to your Kubernetes cluster including Splunk OTel Collector, OpenTelemetry Operator, and Auto-Instrumentation Spec.
3838
2. Apply annotations at the pod or namespace level for the Operator to know which pods to apply auto-instrumentation to.
3939
3. Now, allow the Operator to do the work. As Kuberenetes api requests for create and update annotated pods are processed, the Operator will intercept and alter those requests so that the internal pod application containers are instrumented.
4040

helm-charts/splunk-otel-collector/values.schema.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1809,8 +1809,9 @@
18091809
}
18101810
},
18111811
"certmanager": {
1812-
"description": "cert-manager adds certificates and certificate issuers as resource types in Kubernetes clusters, and simplifies the process of obtaining, renewing and using those certificates.",
1812+
"description": "[Deprecated] cert-manager adds certificates and certificate issuers as resource types in Kubernetes clusters, and simplifies the process of obtaining, renewing and using those certificates.",
18131813
"type": "object",
1814+
"deprecated": true,
18141815
"additionalProperties": true
18151816
},
18161817
"cert-manager": {

helm-charts/splunk-otel-collector/values.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1335,6 +1335,9 @@ instrumentation:
13351335
# value: nginx_value
13361336
# Auto-instrumentation Libraries (End)
13371337

1338+
# Note - Installing certmanager as a subchart is deprecated and will be removed in the future.
1339+
# The recommended approach is to use the chart's default of generating self-signed cert or
1340+
# to install cert-manager separately.
13381341
# The cert-manager is a CNCF application deployed as a subchart and used for supporting operators that require TLS certificates.
13391342
# Full list of Helm value configurations: https://artifacthub.io/packages/helm/cert-manager/cert-manager?modal=values
13401343
certmanager:

0 commit comments

Comments
 (0)