Skip to content

Commit 6034739

Browse files
committed
Ensure entity events are sent via gateway if enabled
1 parent 2afa56b commit 6034739

File tree

11 files changed

+73
-8
lines changed

11 files changed

+73
-8
lines changed
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
2+
change_type: bug_fix
3+
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
4+
component: agent/gateway
5+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
6+
note: Ensure entity events are sent via gateway if enabled.
7+
# One or more tracking issues related to the change
8+
issues: [1732]

examples/collector-all-modes/rendered_manifests/configmap-agent.yaml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,7 @@ data:
2323
tls:
2424
insecure: true
2525
otlphttp/entities:
26-
headers:
27-
X-SF-Token: ${SPLUNK_OBSERVABILITY_ACCESS_TOKEN}
28-
logs_endpoint: https://ingest.CHANGEME.signalfx.com/v3/event
26+
endpoint: http://default-splunk-otel-collector:4318
2927
signalfx:
3028
access_token: ${SPLUNK_OBSERVABILITY_ACCESS_TOKEN}
3129
api_url: http://default-splunk-otel-collector:6060

examples/collector-all-modes/rendered_manifests/configmap-gateway.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ data:
2525
sending_queue:
2626
num_consumers: 32
2727
traces_endpoint: https://ingest.CHANGEME.signalfx.com/v2/trace/otlp
28+
otlphttp/entities:
29+
headers:
30+
X-SF-Token: ${SPLUNK_OBSERVABILITY_ACCESS_TOKEN}
31+
logs_endpoint: https://ingest.CHANGEME.signalfx.com/v3/event
2832
signalfx:
2933
access_token: ${SPLUNK_OBSERVABILITY_ACCESS_TOKEN}
3034
api_url: https://api.CHANGEME.signalfx.com

examples/collector-all-modes/rendered_manifests/daemonset.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ spec:
3232
component: otel-collector-agent
3333
release: default
3434
annotations:
35-
checksum/config: e7a0c25de991c8e1aebf9d671f91c44db517edf929904230adf462ea12d4eb80
35+
checksum/config: e835fc38cee8d6140fb61aa9604e6faa455485306a89d94b3204d97163dc92e6
3636
kubectl.kubernetes.io/default-container: otel-collector
3737
spec:
3838
hostNetwork: true

examples/collector-all-modes/rendered_manifests/deployment-gateway.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ spec:
3131
component: otel-collector
3232
release: default
3333
annotations:
34-
checksum/config: bb199f9676abe8e081c9d1baf013f8765f50cb4a8fbd77e9e3905ddb185fd1da
34+
checksum/config: 6de4353f9d54523f97fd98b7303a67c786c5db29e774e133cf27953b77b3ad30
3535
spec:
3636
serviceAccountName: default-splunk-otel-collector
3737
nodeSelector:

examples/collector-gateway-only/rendered_manifests/configmap-gateway.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ data:
2525
sending_queue:
2626
num_consumers: 32
2727
traces_endpoint: https://ingest.CHANGEME.signalfx.com/v2/trace/otlp
28+
otlphttp/entities:
29+
headers:
30+
X-SF-Token: ${SPLUNK_OBSERVABILITY_ACCESS_TOKEN}
31+
logs_endpoint: https://ingest.CHANGEME.signalfx.com/v3/event
2832
signalfx:
2933
access_token: ${SPLUNK_OBSERVABILITY_ACCESS_TOKEN}
3034
api_url: https://api.CHANGEME.signalfx.com

examples/collector-gateway-only/rendered_manifests/deployment-gateway.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ spec:
3131
component: otel-collector
3232
release: default
3333
annotations:
34-
checksum/config: bb199f9676abe8e081c9d1baf013f8765f50cb4a8fbd77e9e3905ddb185fd1da
34+
checksum/config: 6de4353f9d54523f97fd98b7303a67c786c5db29e774e133cf27953b77b3ad30
3535
spec:
3636
serviceAccountName: default-splunk-otel-collector
3737
nodeSelector:

examples/distribution-eks-fargate/rendered_manifests/configmap-gateway.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,10 @@ data:
2525
sending_queue:
2626
num_consumers: 32
2727
traces_endpoint: https://ingest.CHANGEME.signalfx.com/v2/trace/otlp
28+
otlphttp/entities:
29+
headers:
30+
X-SF-Token: ${SPLUNK_OBSERVABILITY_ACCESS_TOKEN}
31+
logs_endpoint: https://ingest.CHANGEME.signalfx.com/v3/event
2832
signalfx:
2933
access_token: ${SPLUNK_OBSERVABILITY_ACCESS_TOKEN}
3034
api_url: https://api.CHANGEME.signalfx.com

examples/distribution-eks-fargate/rendered_manifests/deployment-gateway.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ spec:
3131
component: otel-collector
3232
release: default
3333
annotations:
34-
checksum/config: 45e83563cc906164f7ae0bfadaa6c5cfea671e742fe7156f3a96805814235100
34+
checksum/config: d7b4d716a875d54e4438f1f4f4b367e4f59f7728b86dd5b30080c833d431a8b3
3535
spec:
3636
serviceAccountName: default-splunk-otel-collector
3737
nodeSelector:

helm-charts/splunk-otel-collector/templates/config/_otel-agent.tpl

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -868,9 +868,13 @@ exporters:
868868

869869
# To send entities (applicable only if discovery mode is enabled)
870870
otlphttp/entities:
871+
{{- if $gatewayEnabled }}
872+
endpoint: http://{{ include "splunk-otel-collector.fullname" . }}:4318
873+
{{- else }}
871874
logs_endpoint: {{ include "splunk-otel-collector.o11yIngestUrl" . }}/v3/event
872875
headers:
873876
"X-SF-Token": ${SPLUNK_OBSERVABILITY_ACCESS_TOKEN}
877+
{{- end }}
874878

875879
{{- if .Values.featureGates.useControlPlaneMetricsHistogramData }}
876880
signalfx/histograms:

helm-charts/splunk-otel-collector/templates/config/_otel-collector.tpl

Lines changed: 44 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,11 @@ exporters:
113113
access_token: ${SPLUNK_OBSERVABILITY_ACCESS_TOKEN}
114114
sending_queue:
115115
num_consumers: 32
116+
# To send entities (applicable only if discovery mode is enabled)
117+
otlphttp/entities:
118+
logs_endpoint: {{ include "splunk-otel-collector.o11yIngestUrl" . }}/v3/event
119+
headers:
120+
"X-SF-Token": ${SPLUNK_OBSERVABILITY_ACCESS_TOKEN}
116121
{{- end }}
117122

118123
{{- if (eq (include "splunk-otel-collector.o11yTracesEnabled" .) "true") }}
@@ -144,6 +149,21 @@ exporters:
144149
{{- if (eq (include "splunk-otel-collector.platformTracesEnabled" .) "true") }}
145150
{{- include "splunk-otel-collector.splunkPlatformTracesExporter" . | nindent 2 }}
146151
{{- end }}
152+
153+
{{- if and
154+
(or (eq (include "splunk-otel-collector.logsEnabled" .) "true") (eq (include "splunk-otel-collector.profilingEnabled" .) "true"))
155+
(eq (include "splunk-otel-collector.splunkO11yEnabled" .) "true")
156+
}}
157+
connectors:
158+
# Routing connector to separate entity events from regular logs
159+
routing/logs:
160+
default_pipelines: [logs]
161+
table:
162+
- context: log
163+
condition: instrumentation_scope.attributes["otel.entity.event_as_log"] == true
164+
pipelines: [logs/entities]
165+
{{- end }}
166+
147167
service:
148168
telemetry:
149169
resource:
@@ -245,9 +265,32 @@ service:
245265
{{- end }}
246266
247267
{{- if or (eq (include "splunk-otel-collector.logsEnabled" .) "true") (eq (include "splunk-otel-collector.profilingEnabled" .) "true") }}
268+
{{- if (eq (include "splunk-otel-collector.splunkO11yEnabled" .) "true") }}
269+
logs/split:
270+
receivers: [otlp]
271+
exporters: [routing/logs]
272+
{{- end }}
273+
{{- if (eq (include "splunk-otel-collector.splunkO11yEnabled" .) "true") }}
274+
# entity events
275+
logs/entities:
276+
receivers:
277+
{{- if or (eq (include "splunk-otel-collector.logsEnabled" .) "true") (eq (include "splunk-otel-collector.profilingEnabled" .) "true") }}
278+
- routing/logs
279+
{{- else }}
280+
- otlp
281+
{{- end }}
282+
receivers: [routing/logs]
283+
processors: [memory_limiter, batch]
284+
exporters: [otlphttp/entities]
285+
{{- end }}
248286
# default logs + profiling data pipeline
249287
logs:
250-
receivers: [otlp]
288+
receivers:
289+
{{- if (eq (include "splunk-otel-collector.splunkO11yEnabled" .) "true") }}
290+
- routing/logs
291+
{{- else }}
292+
- otlp
293+
{{- end }}
251294
processors:
252295
- memory_limiter
253296
- k8sattributes

0 commit comments

Comments
 (0)