Update golangci-lint to 1.50.1 (#2614)

* update version of golangci-lint

* apply new linting rules

* install genny with @latest

Author: atoulme

.github/workflows/go-lint.yml

@@ -13,7 +13,7 @@ concurrency:
 
 env:
   GO_VERSION: 1.18.7
-  LINT_VERSION: 1.48.0
+  LINT_VERSION: 1.50.1
 
 jobs:
   go-lint:

.golangci.yml

@@ -120,6 +120,9 @@ linters:
     - usestdlibvars
     - varnamelen
     - wrapcheck
+    # We disable those new linters as we are looking to minimize code changes.
+    - interfacebloat
+    - contextcheck
 
 
 linters-settings:

Makefile

@@ -89,7 +89,7 @@ image:
 
 .PHONY: tidy
 tidy:
-	go mod tidy -compat=1.17
+	go mod tidy -compat=1.18
 
 .PHONY: signalfx-agent
 signalfx-agent: gofmt

docs/monitors/collectd-jenkins.md

@@ -88,7 +88,7 @@ Configuration](../monitor-config.md#common-configuration).**
 | `path` | no | `string` |  |
 | `metricsKey` | **yes** | `string` | Key required for collecting metrics.  The access key located at `Manage Jenkins > Configure System > Metrics > ADD.` If empty, click `Generate`. |
 | `enhancedMetrics` | no | `bool` | Whether to enable enhanced metrics (**default:** `false`) |
-| `excludeJobMetrics` | no | `bool` | Set to *true* to to exclude job metrics retrieved from `/api/json` endpoint (**default:** `false`) |
+| `excludeJobMetrics` | no | `bool` | Set to *true* to exclude job metrics retrieved from `/api/json` endpoint (**default:** `false`) |
 | `includeMetrics` | no | `list of strings` | Used to enable individual enhanced metrics when `enhancedMetrics` is false |
 | `username` | no | `string` | User with security access to jenkins |
 | `apiToken` | no | `string` | API Token of the user |

pkg/core/agent.go

@@ -27,7 +27,7 @@ import (
 	"github.com/signalfx/signalfx-agent/pkg/utils"
 )
 
-//go:generate sh -c "test -e `go env GOPATH`/bin/genny > /dev/null || (cd ../.. && go install github.com/mauricelam/genny@latest)"
+//go:generate sh -c "test -e `go env GOPATH`/bin/genny > /dev/null || (cd ../.. && go install github.com/mauricelam/genny)"
 
 const (
 	// Items should stay in these channels only very briefly as there should be

pkg/core/config/sources/zookeeper/zookeeper.go

@@ -99,7 +99,7 @@ func (z *zkConfigSource) Get(path string) (map[string][]byte, uint64, error) {
 // ConfigSource since it doesn't have any concept of a global index counter
 // that can be used to ensure updates aren't missed, and it also doesn't have
 // the ability to watch child nodes recursively.  Therefore, for now we just
-// limit globbing to to asterisks at the very end of a node.  If we need more
+// limit globbing to asterisks at the very end of a node.  If we need more
 // complex globbing, consider something like
 // https://github.com/kelseyhightower/confd/blob/master/backends/zookeeper/client.go
 func (z *zkConfigSource) getNodes(path string, watch bool) (map[string][]byte, uint64, []<-chan zk.Event, error) {

pkg/core/writer/dimensions/dedup.go

@@ -81,7 +81,7 @@ func (dd *deduplicator) Add(dim *types.Dimension) {
 	}
 
 	// If we are merging dimension props/tags, then just keep all the updates
-	// in the the cached copy so we will know if an update is going to change
+	// in the cached copy so we will know if an update is going to change
 	// anything or not.
 	if cachedDim.Properties == nil {
 		cachedDim.Properties = map[string]string{}

pkg/monitors/aspdotnet/aspdotnet_windows.go

@@ -88,7 +88,7 @@ func (m *Monitor) Configure(conf *Config) error {
 	// create the accumulator
 	ac := accumulator.NewAccumulator(emitter)
 
-	// create contexts for managing the the plugin loop
+	// create contexts for managing the plugin loop
 	var ctx context.Context
 	ctx, m.cancel = context.WithCancel(context.Background())
 

pkg/monitors/cloudfoundry/monitor.go

@@ -66,7 +66,7 @@ type Monitor struct {
 func (m *Monitor) Configure(conf *Config) error {
 	m.logger = logrus.WithFields(logrus.Fields{"monitorType": monitorType, "monitorID": conf.MonitorID})
 
-	// create contexts for managing the the plugin loop
+	// create contexts for managing the plugin loop
 	var ctx context.Context
 	ctx, m.cancel = context.WithCancel(context.Background())
 

pkg/monitors/collectd/jenkins/jenkins.go

@@ -36,7 +36,7 @@ type Config struct {
 	MetricsKey string `yaml:"metricsKey" validate:"required"`
 	// Whether to enable enhanced metrics
 	EnhancedMetrics *bool `yaml:"enhancedMetrics"`
-	// Set to *true* to to exclude job metrics retrieved from `/api/json` endpoint
+	// Set to *true* to exclude job metrics retrieved from `/api/json` endpoint
 	ExcludeJobMetrics *bool `yaml:"excludeJobMetrics"`
 	// Used to enable individual enhanced metrics when `enhancedMetrics` is
 	// false