Skip to content
This repository was archived by the owner on Jun 2, 2025. It is now read-only.

sync interpolateQueryStr and example docs #22

Open
Malinskiy opened this issue Oct 4, 2019 · 2 comments
Open

sync interpolateQueryStr and example docs #22

Malinskiy opened this issue Oct 4, 2019 · 2 comments

Comments

@Malinskiy
Copy link
Contributor

Before commit 733474e the following used to work:

A = data('metric', filter=filter('tag', '[[tag_value_from_grafana_variable]]')).sum().publish(label='A')

Now since there is interpolation you shouldn't quote the variable which is not what the docs are suggesting.

A = data('metric', filter=filter('tag', [[tag_value_from_grafana_variable]])).sum().publish(label='A')

We should either fix the behaviour or change the examples in docs

@piotr-signalfx
Copy link
Contributor

The changes should not affect single selection variables, please make sure both "Multi-value" and "Include All option" are disabled:
Screen Shot 2020-03-05 at 14 40 06
In case of multiple selection variables the previous implementation did not handle them whatsoever and hence the change.

I agree this behaviour should be described better in the docs.

@zerolaser
Copy link

@Malinskiy @piotr-signalfx Any progress on when this issue gets merged ?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants