better error handling, start blocking out MySQL support

Author: thisisaaronland

sql/database.go

@@ -46,10 +46,18 @@ func OpenWithURI(ctx context.Context, db_uri string) (*sql.DB, error) {
 	engine := u.Host
 	dsn := q.Get("dsn")
 
+	if engine == "" {
+		return nil, fmt.Errorf("Missing database engine")
+	}
+
+	if dsn == "" {
+		return nil, fmt.Errorf("Missing DSN string")
+	}
+
 	db, err := sql.Open(engine, dsn)
 
 	if err != nil {
-		return nil, fmt.Errorf("Unable to create database (%s) because %v", db_uri, err)
+		return nil, fmt.Errorf("Unable to create database (%s) because %v", engine, err)
 	}
 
 	switch Driver(db) {

sql/database_test.go

@@ -0,0 +1,41 @@
+package sql
+
+import (
+	_ "context"
+	"net/url"
+	"testing"
+)
+
+func TestOpenWithURIEngine(t *testing.T) {
+
+	tests := map[string]string{
+		"sql://mysql/?dsn={...}@tcp(sfomuseum-debug.hdhdhhdjs99.us-east-1.rds.amazonaws.com)/sfomueum_debug&tls=true": "mysql",
+	}
+
+	for db_uri, expected := range tests {
+
+		u, err := url.Parse(db_uri)
+
+		if err != nil {
+			t.Fatalf("Failed to parse db_uri, %v", err)
+		}
+
+		q := u.Query()
+
+		engine := u.Host
+		dsn := q.Get("dsn")
+
+		if engine == "" {
+			t.Fatal("Missing engine")
+		}
+
+		if dsn == "" {
+			t.Fatal("Missing dsn")
+		}
+
+		if engine != expected {
+			t.Fatalf("Invalid engine. Got '%s' but expected '%s'", engine, expected)
+		}
+
+	}
+}

sql/driver.go

@@ -30,6 +30,8 @@ func Driver(db *sql.DB) string {
 		return POSTGRES_DRIVER
 	case "duckdb.Driver", "*duckdb.Driver":
 		return DUCKDB_DRIVER
+	case "*mysql.MySQLDriver", "mysql.MySQLDriver":
+		return MYSQL_DRIVER
 	default:
 		slog.Warn("Unhandled driver type", "type", driver_type)
 		return ""

sql/mysql.go

@@ -0,0 +1,11 @@
+package sql
+
+import (
+	"context"
+	"database/sql"
+	"fmt"
+)
+
+func ConfigureMySQLDatabase(ctx context.Context, db *sql.DB, opts *ConfigureDatabaseOptions) error {
+	return fmt.Errorf("Not implemented.")
+}