Skip to content

Commit 8a0a8ae

Browse files
committed
Moved CancellationToken to end of parameter list
1 parent 47bfdf0 commit 8a0a8ae

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

CSharpHTTPClient/Client.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -294,7 +294,7 @@ public override bool TryInvokeMember(InvokeMemberBinder binder, object[] args, o
294294
}
295295
i++;
296296
}
297-
result = RequestAsync(binder.Name.ToUpper(), cancellationToken, requestBody: requestBody, queryParams: queryParams).ConfigureAwait(false);
297+
result = RequestAsync(binder.Name.ToUpper(), requestBody: requestBody, queryParams: queryParams, cancellationToken: cancellationToken).ConfigureAwait(false);
298298
return true;
299299
}
300300
else
@@ -312,10 +312,10 @@ public override bool TryInvokeMember(InvokeMemberBinder binder, object[] args, o
312312
/// <param name="request">The parameters for the API call</param>
313313
/// <param name="cancellationToken">A token that allows cancellation of the http request</param>
314314
/// <returns>Response object</returns>
315-
public async virtual Task<Response> MakeRequest(HttpClient client, HttpRequestMessage request, CancellationToken cancellationToken)
315+
public async virtual Task<Response> MakeRequest(HttpClient client, HttpRequestMessage request, CancellationToken cancellationToken = default(CancellationToken))
316316
{
317317

318-
HttpResponseMessage response = await client.SendAsync(request).ConfigureAwait(false);
318+
HttpResponseMessage response = await client.SendAsync(request, cancellationToken).ConfigureAwait(false);
319319
return new Response(response.StatusCode, response.Content, response.Headers);
320320
}
321321

@@ -327,7 +327,7 @@ public async virtual Task<Response> MakeRequest(HttpClient client, HttpRequestMe
327327
/// <param name="requestBody">JSON formatted string</param>
328328
/// <param name="queryParams">JSON formatted queary paramaters</param>
329329
/// <returns>Response object</returns>
330-
private async Task<Response> RequestAsync(string method, String requestBody = null, String queryParams = null, CancellationToken cancellationToken = null)
330+
private async Task<Response> RequestAsync(string method, String requestBody = null, String queryParams = null, CancellationToken cancellationToken = default(CancellationToken))
331331
{
332332
using (var client = new HttpClient())
333333
{

0 commit comments

Comments
 (0)