Cleanup temporary files 🧹

Author: skipi

cmd/gen-pipeline-report.go

@@ -57,6 +57,7 @@ var genPipelineReportCmd = &cobra.Command{
 				logger.Error("Creating temporary directory failed %v", err)
 				return err
 			}
+			defer os.RemoveAll(dir)
 
 			dir, err = cli.PullArtifacts("workflow", path.Join("test-results", pipelineID), dir, cmd)
 			if err != nil {
@@ -82,13 +83,13 @@ var genPipelineReportCmd = &cobra.Command{
 			return err
 		}
 
-		defer os.deletefileName.
-
 		_, err = cli.PushArtifacts("workflow", fileName, path.Join("test-results", pipelineID+".json"), cmd)
 		if err != nil {
 			return err
 		}
 
+		defer os.Remove(fileName)
+
 		return nil
 	},
 }

cmd/publish.go

@@ -146,6 +146,8 @@ var publishCmd = &cobra.Command{
 			}
 		}
 
+		defer os.Remove(fileName)
+
 		return nil
 	},
 }

pkg/cli/cli.go

@@ -324,7 +324,7 @@ func MergeFiles(path string, cmd *cobra.Command) (*parser.Result, error) {
 }
 
 // Load ...
-// [TODO]: TEST THIS!!!
+// [TODO]: Test this
 func Load(path string) (*parser.Result, error) {
 	var result parser.Result
 	jsonFile, err := os.Open(path)