Skip to content

Commit 505cd3c

Browse files
authored
Merge pull request #7 from SvMak/small-improvements
Small improvements
2 parents b318f36 + 245335d commit 505cd3c

File tree

6 files changed

+12
-3
lines changed

6 files changed

+12
-3
lines changed

src/components/CarbonAds/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ export default function CarbonAds({ code, placement }: Props) {
1111
const s = document.createElement('script');
1212
s.async = true;
1313
s.id = '_carbonads_js';
14-
s.src = `//cdn.carbonads.com/carbon.js?serve=${code}&placement=${placement}`;
14+
s.src = `https://cdn.carbonads.com/carbon.js?serve=${code}&placement=${placement}`;
1515
ref.current.appendChild(s);
1616
}
1717
}, []);

src/components/sections/Hero/index.tsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ export default function Hero() {
1010
className={styles.sectionTopImg}
1111
src="/assets/img/sdk-man-small-pattern.svg"
1212
alt="SDKMAN! logo"
13+
width={250}
14+
height={145}
1315
/>
1416

1517
<h1 className={styles.sectionTopTitle}>

src/components/sections/Hero/styles.module.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929

3030
&Img {
3131
width: 250px;
32+
height: auto;
3233
}
3334
}
3435

src/components/sections/OpenCollective/Buttons/OCButton/index.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ export default function OCButton() {
1313
alt="Donate"
1414
width={240}
1515
height={35}
16+
loading="lazy"
1617
/>
1718
</Link>
1819
);

src/components/ui/AvatarImage/index.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ export default function AvatarImage({ className, src, alt }: Props) {
1313
return <span className={clsx(styles.avatarImage, className)}>{name}</span>;
1414
}
1515

16-
return <img className={className} src={src} alt={`${alt} avatar`} />;
16+
return (
17+
<img className={className} src={src} alt={`${alt} avatar`} loading="lazy" />
18+
);
1719
}
1820

1921
function generateAvatar(value: string) {

src/pages/index.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,10 @@ import PageCarbonAds from '@site/src/components/sections/PageCarbonAds';
77

88
export default function WelcomePage() {
99
return (
10-
<Layout title="Home">
10+
<Layout
11+
title="Home"
12+
description="SDKMAN! is a tool for managing parallel versions of multiple Software Development Kits on most Unix based systems."
13+
>
1114
<PageCarbonAds />
1215
<Hero />
1316

0 commit comments

Comments
 (0)